Add type hint, update to pyo3 0.27, add automatic type hint generator#1928
Merged
Conversation
…s to be uv related
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Closed
McPatate
reviewed
Feb 2, 2026
McPatate
left a comment
Member
There was a problem hiding this comment.
Did you make sure the doc strings in the removed pyi files didn't have any drift with the docstrings in code? As in, any additional up to date documentation not present in the code files?
Looks great other than that! Nice work!
| Digits = pre_tokenizers.Digits | ||
| FixedLength = pre_tokenizers.FixedLength | ||
| Metaspace = pre_tokenizers.Metaspace | ||
| PreTokenizer = pre_tokenizers.PreTokenizer |
Member
There was a problem hiding this comment.
did you do that yourself or is it ty that auto-sorts alphabetically?
in any case, 💆🏻
| A tuple with the string representation of the CLS token, and its id | ||
| """ | ||
| def __init__(self, sep, cls): | ||
| def __init__(self, sep: tuple[str, int], _cls: tuple[str, int]): |
Member
There was a problem hiding this comment.
is _cls used at all? do we leave it for backwards compat?
ArthurZucker
marked this pull request as draft
February 2, 2026 16:14
Collaborator
Author
|
Waiting for docstring support! |
- Replace complex modifications dict with simple insertions list - Remove nested process_function_or_method function - Use bottom-to-top line replacement for cleaner logic - Remove unused importlib import
ArthurZucker
force-pushed
the
more-typehint
branch
from
February 3, 2026 16:13
df690a0 to
089f1cd
Compare
ArthurZucker
marked this pull request as ready for review
February 6, 2026 09:00
- Move stub_generation.rs to tools/stub-gen/ as standalone crate - Remove stub-gen feature and pyo3-introspection from main crate - Auto-detect PYTHONHOME for uv/venv environments - Update Makefile and README with new instructions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
McPatate
approved these changes
Feb 11, 2026
Closed
MayCXC
pushed a commit
to MayCXC/tokenizers
that referenced
this pull request
Apr 4, 2026
…huggingface#1928) * something that is supposed to work but my env does not allow it, seems to be uv related * ? * up * nits * let' s try * part of tthe update for pyo3 0.27 * more pyo3 fixes * update * does this help? * help * finally * update stub accordingly * export more of the submodules * moooore * add individual .pypi * cleanup * update pyo3 signatures and fix warning * style * update * more updates * sytle * clippy happy * does this help? * fix * fix * ? * what? * add dwarwub case co * up? * update * clippy and fmt * this time it works * remove offending one * update * remove shit * remove more shit that was unwanted * ? * simplify a bit * more verbose? * more simplification * fmt * fix some of the typing in rust directly to please TY (but also just fix some typing.Any * fix script running * fix , ignore and exclude * style * update * fmt + add it to style? * cleanup * Simplify stub.py docstring injection - Replace complex modifications dict with simple insertions list - Remove nested process_function_or_method function - Use bottom-to-top line replacement for cleaner logic - Remove unused importlib import * isolate stub generation into separate tools/stub-gen crate - Move stub_generation.rs to tools/stub-gen/ as standalone crate - Remove stub-gen feature and pyo3-introspection from main crate - Auto-detect PYTHONHOME for uv/venv environments - Update Makefile and README with new instructions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
lalala-233
reviewed
May 2, 2026
There was a problem hiding this comment.
Oh bro, you rename cls to cls_token, breaking the compatibility. I don't know why you did this.
In this commit: 354a484
Collaborator
Author
|
That's why the release is breaking 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ty pyo3!
PyO3/pyo3#5137