publish_all() method for Topic [API-1529]#570
Merged
mehmettokgoz merged 8 commits intohazelcast:masterfrom Oct 26, 2022
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
==========================================
- Coverage 96.47% 96.44% -0.03%
==========================================
Files 355 349 -6
Lines 20351 19604 -747
==========================================
- Hits 19633 18908 -725
+ Misses 718 696 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3742c90 to
e780eee
Compare
Contributor
|
@mehmettokgoz Could you add a test for this? |
mdumandag
reviewed
Sep 23, 2022
Contributor
mdumandag
left a comment
There was a problem hiding this comment.
Also, please add tests
Contributor
Author
|
Added tests for publish_all() under integration tests. |
added 2 commits
October 10, 2022 08:27
mdumandag
reviewed
Oct 12, 2022
Contributor
mdumandag
left a comment
There was a problem hiding this comment.
You also need to add tests to the TopicCompactCompatibilityTest to make sure that your code works with Compact serialized objects as well
Contributor
Author
|
Compact compatibility test is added at 945b965. |
mdumandag
reviewed
Oct 25, 2022
...ration/backward_compatible/serialization/compact_compatibility/compact_compatibility_test.py
Show resolved
Hide resolved
mdumandag
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added codec for publish all message.