Fix body read blocking on socket timeout instead of Content-Length#18
Open
Kruseltier wants to merge 1 commit intohaproxytech:masterfrom
Open
Fix body read blocking on socket timeout instead of Content-Length#18Kruseltier wants to merge 1 commit intohaproxytech:masterfrom
Kruseltier wants to merge 1 commit intohaproxytech:masterfrom
Conversation
socket:receive("*a") reads until the server closes the connection (EOF).
When the server doesn't immediately close the connection (e.g. due to
keep-alive or TCP linger behavior), this blocks until the socket timeout
(default 5 seconds).
Fix by reading exactly Content-Length bytes with socket:receive(n), which
returns as soon as the specified number of bytes have been received,
regardless of connection state.
This matches the behavior already used in receive_chunked(), which
correctly reads chunk_len+2 bytes rather than reading until EOF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
socket:receive("*a") reads until the server closes the connection (EOF). When the server doesn't immediately close the connection (e.g. due to keep-alive or TCP linger behavior), this blocks until the socket timeout (default 5 seconds).
Fix by reading exactly Content-Length bytes with socket:receive(n), which returns as soon as the specified number of bytes have been received, regardless of connection state.
This matches the behavior already used in receive_chunked(), which correctly reads chunk_len+2 bytes rather than reading until EOF.