Skip to content

Add field for reimbursement reason#922

Merged
jackyyzhang03 merged 1 commit intodevfrom
jacky/travel-reimbursement-page
Nov 3, 2023
Merged

Add field for reimbursement reason#922
jackyyzhang03 merged 1 commit intodevfrom
jacky/travel-reimbursement-page

Conversation

@jackyyzhang03
Copy link
Member

@jackyyzhang03 jackyyzhang03 commented Nov 3, 2023

Tickets:

List of changes:

  • Modified Hacker model to include a reason in addition to the reimbursement amount.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@jackyyzhang03 jackyyzhang03 changed the title feat: add field for reimbursement reason Add field for reimbursement reason Nov 3, 2023
@jackyyzhang03 jackyyzhang03 merged commit 01aec67 into dev Nov 3, 2023
@jackyyzhang03 jackyyzhang03 deleted the jacky/travel-reimbursement-page branch November 3, 2023 20:21
jackyyzhang03 added a commit that referenced this pull request Nov 15, 2023
* feat(hacker.js,hacker.middleware.js): add ability for discord verification. (#795)

* feat(hacker.js,hacker.middleware.js): add ability for discord verification..

* fix(hacker.js): typo in middleware function call.

* add postDiscord role/route

* Fix hacker discord route

Co-authored-by: meldunn <dmelissa216@gmail.com>

* change invite to disc (#799)

* change invite to disc

* remove fb group

* fix/update emails (#882)

* feat(hacker.js,hacker.middleware.js): add ability for discord verification..

* fix(hacker.js): typo in middleware function call.

* add postDiscord role/route

* fix: update applied email

Co-authored-by: meldunn <dmelissa216@gmail.com>

* Jacky/email (#900)

* fix: change to mchacks 10 in email templates

* fix: dates

* fix: move confirmation date +1 day

Co-authored-by: Jacky Zhang <jackyyzhang@gmail.com>

* Fix/check in discord (#905)

* fix: change to mchacks 10 in email templates

* fix: dates

* fix: move confirmation date +1 day

* Fix: check in discord

---------

* feat: add field for reimbursement reason (#922)

* feat: set cookie SameSite using env variable

---------

Co-authored-by: Anmol Brar <83686967+brarsanmol@users.noreply.github.com>
Co-authored-by: meldunn <dmelissa216@gmail.com>
Co-authored-by: Yun Kai Peng <45922265+pengyk@users.noreply.github.com>
jackyyzhang03 added a commit that referenced this pull request Dec 21, 2023
* feat(hacker.js,hacker.middleware.js): add ability for discord verification. (#795)

* feat(hacker.js,hacker.middleware.js): add ability for discord verification..

* fix(hacker.js): typo in middleware function call.

* add postDiscord role/route

* Fix hacker discord route

Co-authored-by: meldunn <dmelissa216@gmail.com>

* change invite to disc (#799)

* change invite to disc

* remove fb group

* fix/update emails (#882)

* feat(hacker.js,hacker.middleware.js): add ability for discord verification..

* fix(hacker.js): typo in middleware function call.

* add postDiscord role/route

* fix: update applied email

Co-authored-by: meldunn <dmelissa216@gmail.com>

* Jacky/email (#900)

* fix: change to mchacks 10 in email templates

* fix: dates

* fix: move confirmation date +1 day

Co-authored-by: Jacky Zhang <jackyyzhang@gmail.com>

* Fix/check in discord (#905)

* fix: change to mchacks 10 in email templates

* fix: dates

* fix: move confirmation date +1 day

* Fix: check in discord

---------

* feat: add field for reimbursement reason (#922)

* feat: set cookie SameSite using env variable

* feat: update status update emails

---------

Co-authored-by: Anmol Brar <83686967+brarsanmol@users.noreply.github.com>
Co-authored-by: meldunn <dmelissa216@gmail.com>
Co-authored-by: Yun Kai Peng <45922265+pengyk@users.noreply.github.com>
jackyyzhang03 added a commit that referenced this pull request Jan 17, 2024
* feat(hacker.js,hacker.middleware.js): add ability for discord verification. (#795)

* feat(hacker.js,hacker.middleware.js): add ability for discord verification..

* fix(hacker.js): typo in middleware function call.

* add postDiscord role/route

* Fix hacker discord route

Co-authored-by: meldunn <dmelissa216@gmail.com>

* change invite to disc (#799)

* change invite to disc

* remove fb group

* fix/update emails (#882)

* feat(hacker.js,hacker.middleware.js): add ability for discord verification..

* fix(hacker.js): typo in middleware function call.

* add postDiscord role/route

* fix: update applied email

Co-authored-by: meldunn <dmelissa216@gmail.com>

* Jacky/email (#900)

* fix: change to mchacks 10 in email templates

* fix: dates

* fix: move confirmation date +1 day

Co-authored-by: Jacky Zhang <jackyyzhang@gmail.com>

* Fix/check in discord (#905)

* fix: change to mchacks 10 in email templates

* fix: dates

* fix: move confirmation date +1 day

* Fix: check in discord

---------

* feat: add field for reimbursement reason (#922)

* feat: set cookie SameSite using env variable

* feat: update status update emails

* feat: remove facebook and twitter from status emails

---------

Co-authored-by: Anmol Brar <83686967+brarsanmol@users.noreply.github.com>
Co-authored-by: meldunn <dmelissa216@gmail.com>
Co-authored-by: Yun Kai Peng <45922265+pengyk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments