Skip to content

Export settings as .json instead of .txt#512

Open
todofixthis wants to merge 1 commit intohackademix:mainfrom
todofixthis:fix/export-json-extension
Open

Export settings as .json instead of .txt#512
todofixthis wants to merge 1 commit intohackademix:mainfrom
todofixthis:fix/export-json-extension

Conversation

@todofixthis
Copy link

@todofixthis todofixthis commented Feb 8, 2026

Summary

  • Change settings export download filename from noscript_data.txt to noscript_data.json and update MIME type from text/plain to application/json
  • Fix missing execute permission on build.sh

The exported settings have always been JSON; this aligns the file extension and content type accordingly. No changes needed on the import side, as it already parses the content as JSON regardless of file extension.

Test plan

Here are the steps I took to test this behaviour. I only tested in Firefox as the change feels trivial.

  • Load unpacked extension in Firefox (about:debugging → Load Temporary Add-on)
  • Open NoScript options → click Export
  • Verify downloaded file is named noscript_data.json
  • Verify the file contains valid JSON
  • Re-import the exported .json file and confirm settings restore correctly
  • Verify ./build.sh -u debug runs without needing bash prefix

🤖 Co-generated with Claude Code

Change download filename to noscript_data.json and MIME
type to application/json. Also fix build.sh execute bit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant