Fixes encouragement at the end of the document#11
Merged
Conversation
When the caret is at the very end of the document the trigger point comes back as the end point of the document. The equivalent of ``` new Snapshot(snapshot, snapshot.Length); ``` We then created a tracking span of trigger point + 1. This creates a point past the end of the buffer and hence caused an exception to be raised. The fix is to simply have a 0 length tracking span here.
haacked
added a commit
that referenced
this pull request
Jun 30, 2014
Fixes encouragement at the end of the document
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the caret is at the very end of the document the trigger point
comes back as the end point of the document. The equivalent of
We then created a tracking span of trigger point + 1. This creates a
point past the end of the buffer and hence caused an exception to be
raised. The fix is to simply have a 0 length tracking span here.