Fix MainWindow 'populate' method #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the MainWindow.populate method to behave in a more "additive" manner: calling it will no longer clear/re-create the associated QComboBox items and folders/history views widgets, thereby fixing the bug which required users to re-start the application in the event of joining a new grid via the Welcome dialog due to disconnected Qt Signals/Slots. In addition, adding a new grid will now select it immediately in the combobox, making it more obvious that the new grid has been joined and facilitating adding new folders afterward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the MainWindow.populate method to behave in a more
"additive" manner: calling it will no longer clear/re-create the
associated QComboBox items and folders/history views widgets, thereby
fixing the bug which required users to re-start the application in the
event of joining a new grid via the Welcome dialog due to disconnected
Qt Signals/Slots. In addition, adding a new grid will now select it
immediately in the combobox, making it more obvious that the new grid
has been joined and facilitating adding new folders afterward.