Add JSpecify annotations to 14 classes in graphql.language package (final batch) by Copilot · Pull Request #4221 · graphql-java/graphql-java

Copilot · 2026-01-25T06:36:45Z

Completes JSpecify annotation coverage for the graphql.language package by annotating the remaining 14 classes.

Changes

Annotated classes:

Interfaces: SDLNamedDefinition, Selection, SelectionSetContainer, TypeDefinition
Enum: TypeKind
Concrete classes: ScalarTypeDefinition, ScalarTypeExtensionDefinition, SchemaDefinition, SchemaExtensionDefinition, SelectionSet, TypeName, UnionTypeDefinition, UnionTypeExtensionDefinition, VariableDefinition

Pattern applied:

@NullMarked at class level
@NullUnmarked on static Builder classes
@Nullable on fields/parameters that accept null: SourceLocation, Description, Value defaultValue, SelectionSet
assertNotNull() wrapping deepCopy() results passed to constructors expecting non-null lists

Ripple effect fix:

Updated Anonymizer.java to use assertNotNull() when passing condition strings to TypeName constructor (now requires non-null after annotation)

Exemption list:

Removed all 14 classes from JSpecifyAnnotationsCheck.groovy

Original prompt

Task

Add JSpecify annotations to the following 14 classes in the graphql.language package (final batch for this package), following the established JSpecify annotation pattern documented in .claude/commands/jspecify-annotate.md.

Classes to annotate

graphql.language.SDLNamedDefinition

graphql.language.ScalarTypeDefinition

graphql.language.ScalarTypeExtensionDefinition

graphql.language.SchemaDefinition

graphql.language.SchemaExtensionDefinition

graphql.language.Selection

graphql.language.SelectionSet

graphql.language.SelectionSetContainer

graphql.language.TypeDefinition

graphql.language.TypeKind

graphql.language.TypeName

graphql.language.UnionTypeDefinition

graphql.language.UnionTypeExtensionDefinition

graphql.language.VariableDefinition

Instructions

Follow the JSpecify annotation process documented in .claude/commands/jspecify-annotate.md:

Set each class to be @NullMarked at the class level

Remove all redundant @NonNull annotations that IntelliJ may have added

Check Javadoc for @param tags mentioning "null", "nullable", "may be null"

Check Javadoc @return tags mentioning "null", "optional", "if available"

Inspect method implementations that return null or check for null

Consider GraphQL specification details when determining nullability

For Builder static classes, label them @NullUnmarked and no further annotations needed

Validation

After making changes, run the NullAway compile check:
./gradlew compileJava
If you find NullAway errors, make the smallest possible change to fix them. You can use assertNotNull with a message if needed.

Cleanup

Remove each completed class from the exemption list in src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy

Delete all unused imports from the classes you've annotated

Do not make spacing or formatting changes - only make minimal changes necessary for the annotations

Reference

Look at existing annotated classes like IntValue.java, StringValue.java, AbstractNode.java in the same package for reference patterns.

This pull request was created from Copilot chat.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: dondonz <13839920+dondonz@users.noreply.github.com>

…time

github-actions · 2026-02-20T21:20:31Z

Test Results

335 files ±0 335 suites ±0 5m 6s ⏱️ -1s
5 376 tests +5 5 368 ✅ +5 8 💤 ±0 0 ❌ ±0
5 465 runs +5 5 457 ✅ +5 8 💤 ±0 0 ❌ ±0

Results for commit 6c8e1f3. ± Comparison against base commit 89b4446.

This pull request removes 449 and adds 430 tests. Note that renamed tests count towards both.

	?

	, expected: combo-\"\\\b\f\n\r\t, #4]
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
…

graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@1e60b459 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@7c0777b5 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@29ebbdf4 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@6ba060f3 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@411a5965 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@18a25bbd delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@5a0bef24 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@17092fff delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@22c75c01 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of error args with non null does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_6prov0_closure6@63d5874f delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1, #0]
…

♻️ This comment has been updated with latest results.

dondonz · 2026-02-27T21:02:40Z

Closing the 2nd batch of Copilot PRs after finding multiple errors. I will redo

Copilot AI and others added 4 commits January 24, 2026 20:32

Initial plan

c60fdf6

Add JSpecify annotations to 10 classes in graphql.language package

c02fa4e

Co-authored-by: dondonz <13839920+dondonz@users.noreply.github.com>

Update JSpecify annotation prompt with effectiveness improvements

3db2dde

Co-authored-by: dondonz <13839920+dondonz@users.noreply.github.com>

Initial plan

4bdefd7

Copilot AI assigned Copilot and dondonz Jan 25, 2026

Copilot started work on behalf of dondonz January 25, 2026 07:01 View session

Add JSpecify annotations to 14 classes in graphql.language package

ffadaba

Co-authored-by: dondonz <13839920+dondonz@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add JSpecify annotations to 14 classes in graphql.language package~~ Add JSpecify annotations to 14 classes in graphql.language package (final batch) Jan 25, 2026

Copilot finished work on behalf of dondonz January 25, 2026 07:27

Copilot AI requested a review from dondonz January 25, 2026 07:27

Copilot AI mentioned this pull request Jan 28, 2026

Review all open JSpecify PRs #4231

Draft

dondonz changed the base branch from copilot/add-jspecify-annotations-to-classes to master February 8, 2026 07:16

Merge branch 'master' into copilot/add-jspecify-annotations-one-more-…

6c8e1f3

…time

dondonz closed this Feb 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JSpecify annotations to 14 classes in graphql.language package (final batch)#4221

Add JSpecify annotations to 14 classes in graphql.language package (final batch)#4221
Copilot wants to merge 6 commits intomasterfrom
copilot/add-jspecify-annotations-one-more-time

Copilot AI commented Jan 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 20, 2026 •

edited

Loading

Uh oh!

dondonz commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Task

Classes to annotate

Instructions

Validation

Cleanup

Reference

Uh oh!

github-actions bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

dondonz commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 25, 2026 •

edited

Loading

github-actions bot commented Feb 20, 2026 •

edited

Loading