1181 Fix null element in InputValueDefinition#getChildren#1182
Merged
andimarek merged 2 commits intographql-java:masterfrom Aug 23, 2018
Merged
1181 Fix null element in InputValueDefinition#getChildren#1182andimarek merged 2 commits intographql-java:masterfrom
andimarek merged 2 commits intographql-java:masterfrom
Conversation
johnliucn925
approved these changes
Aug 21, 2018
Member
|
@tsroka how did you come across this? |
Member
|
@tsroka could u use the graphql-java formatter (https://github.com/graphql-java/graphql-java/blob/master/graphql-java-code-style.xml) to avoid not needed changes? thanks |
Author
|
@andimarek while working on nadel, i needed to traverse AST using NodeTraverser and got NPE. Will fix formatting, |
Member
|
this should also go into stable 9.x |
bbakerman
added a commit
to bbakerman/graphql-java
that referenced
this pull request
Aug 30, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.