Skip to content

chore: replace setup-scala action - #522

Merged
rjurney merged 1 commit into
graphframes:masterfrom
SemyonSinchenko:514-setup-scala
Feb 25, 2025
Merged

chore: replace setup-scala action#522
rjurney merged 1 commit into
graphframes:masterfrom
SemyonSinchenko:514-setup-scala

Conversation

@SemyonSinchenko

@SemyonSinchenko SemyonSinchenko commented Feb 25, 2025

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

  • replace outdated olafurpg/setup-scala by setup-java action
  • force the run of the scalafmtCheckAll during the CI

Why are the changes needed?

As described in #514

Close #514

+ force scalfmt checkAll during the CI
@SemyonSinchenko

Copy link
Copy Markdown
Collaborator Author

@rjurney @bjornjorgensen Hello! Could you review this one when you have time? Thanks!

@rjurney rjurney left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread .github/workflows/scala-ci.yml
Comment thread .github/workflows/python-ci.yml

@bjornjorgensen bjornjorgensen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjornjorgensen

Copy link
Copy Markdown
Contributor

@SemyonSinchenko if you type fix #514 in the PR they will be linked and the 514 will be closed automatically when this PR is merged.

@rjurney

rjurney commented Feb 25, 2025

Copy link
Copy Markdown
Collaborator

fix #514

@rjurney
rjurney merged commit 6782187 into graphframes:master Feb 25, 2025
@SemyonSinchenko
SemyonSinchenko deleted the 514-setup-scala branch April 6, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace olafurpg/setup-scala

3 participants