Skip to content
This repository was archived by the owner on Jul 6, 2023. It is now read-only.

Conversation

@dandhlee
Copy link
Contributor

When there is a patch version added to semver versioning, setuptools.setup(version) will normalize the versioning from -patch to .patch which is not correct SEMVER versioning. The added feature with setuptools.sic(version) will prevent this from happening.

@dandhlee dandhlee added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 16, 2021
@dandhlee dandhlee requested a review from a team as a code owner April 16, 2021 04:40
@product-auto-label product-auto-label bot added the api: managedidentities Issues related to the googleapis/python-managed-identities API. label Apr 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2021
@dandhlee dandhlee removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 16, 2021
@dandhlee dandhlee added the automerge Merge the pull request once unit tests and other checks pass. label Apr 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 44d0ad1 into master Apr 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the remove-semver-normalization branch April 16, 2021 21:24
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: managedidentities Issues related to the googleapis/python-managed-identities API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants