Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Oct 6, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@parthea parthea requested a review from a team as a code owner October 6, 2022 20:06
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: cloudkms Issues related to the googleapis/python-kms API. labels Oct 6, 2022
@vchudnov-g vchudnov-g merged commit cfdad0a into main Oct 7, 2022
@vchudnov-g vchudnov-g deleted the allow-protobuf-3-19-5 branch October 7, 2022 20:49
@parthea parthea restored the allow-protobuf-3-19-5 branch October 10, 2022 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: cloudkms Issues related to the googleapis/python-kms API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants