Skip to content

feat: add deprecation warning to Gemini-1.5-X, text-embedding-004, and remove remove legacy models in notebooks and docs #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shuoweil merged 9 commits into from
May 16, 2025
Merged

feat: add deprecation warning to Gemini-1.5-X, text-embedding-004, and remove remove legacy models in notebooks and docs #1723

shuoweil merged 9 commits into from
May 16, 2025

Conversation

@shuoweil
Copy link
Contributor

@shuoweil shuoweil commented May 12, 2025

feat: add deprecation warning to Gemini-1.5-X, text-embedding-004, and remove Remove legacy models in notebooks and docs
b/416566349

@shuoweil shuoweil requested review from GarrettWu and Genesis929 May 12, 2025 22:35
@shuoweil shuoweil self-assigned this May 12, 2025
@shuoweil shuoweil requested review from a team as code owners May 12, 2025 22:35
@shuoweil shuoweil requested a review from nicain May 12, 2025 22:35
@review-notebook-app
Copy link

review-notebook-app bot commented May 12, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 12, 2025
@shuoweil shuoweil force-pushed the shuowei-remove-legacy-models branch from 2a2c83e to 31e26cd Compare May 13, 2025 00:32
GarrettWu
GarrettWu reviewed May 13, 2025
View reviewed changes
@shuoweil shuoweil force-pushed the shuowei-remove-legacy-models branch from 31e26cd to 58a26bc Compare May 13, 2025 21:03
@shuoweil shuoweil requested a review from GarrettWu May 13, 2025 21:04
@GarrettWu
Copy link
Contributor

GarrettWu commented May 14, 2025

Semantic tests are failing

@shuoweil shuoweil force-pushed the shuowei-remove-legacy-models branch from 58a26bc to 611b8fe Compare May 14, 2025 00:31
@shuoweil
Copy link
Contributor Author

shuoweil commented May 14, 2025 •
edited
Loading

Semantic tests are failing

I debug one of the failed tests (screen/6TVFXZfFb57tcn8). We are expecting the results "capybara is heavier than spider". But the actual result returns "capybara is heavier than capybara". See debug result here (screen/5k5JyS2ghyj4KYQ).

I changed the gemini model from gemini-1.5 to gemini-2.0-flash-001. It looks like the result with "gemini-2.0-flash-001" is wrong. I also tried "gemini-2.0-flash-lite-001", the same test past. @sycai

@shuoweil shuoweil requested a review from sycai May 14, 2025 22:30
@sycai
Copy link
Contributor

sycai commented May 14, 2025

Updated the ai.self_join() test case with a more dramatic example. Let's see how it goes.

@shuoweil
Copy link
Contributor Author

shuoweil commented May 14, 2025

Updated the ai.self_join() test case with a more dramatic example. Let's see how it goes.

It looks like gemini-2.0-flash-001 does not like capybara. Test case change helps. Thanks!

@shuoweil shuoweil force-pushed the shuowei-remove-legacy-models branch from 34a1165 to 4945737 Compare May 14, 2025 23:47
@shuoweil
Copy link
Contributor Author

shuoweil commented May 14, 2025

Semantic tests are failing

all failed tests are fix

GarrettWu
GarrettWu previously approved these changes May 15, 2025
View reviewed changes
@GarrettWu GarrettWu self-requested a review May 15, 2025 18:13
@GarrettWu GarrettWu dismissed their stale review May 15, 2025 18:14

misclick

@shuoweil shuoweil force-pushed the shuowei-remove-legacy-models branch from 3e1861e to ca3c21e Compare May 15, 2025 20:53
@shuoweil shuoweil changed the title feat: add deprecation warning to Gemini-1.5-X, text-embedding-004, and remove Remove legacy models in notebooks and docs feat: add deprecation warning to Gemini-1.5-X, text-embedding-004, and remove remove legacy models in notebooks and docs May 15, 2025
@shuoweil shuoweil force-pushed the shuowei-remove-legacy-models branch from ca3c21e to 4f0019f Compare May 16, 2025 04:22
GarrettWu
GarrettWu approved these changes May 16, 2025
View reviewed changes
@shuoweil shuoweil force-pushed the shuowei-remove-legacy-models branch from 4f0019f to ee474ea Compare May 16, 2025 21:17
@shuoweil shuoweil enabled auto-merge (squash) May 16, 2025 21:18
@shuoweil shuoweil merged commit 80aad9a into main May 16, 2025
20 of 24 checks passed
@shuoweil shuoweil deleted the shuowei-remove-legacy-models branch May 16, 2025 22:17
@release-please release-please bot mentioned this pull request May 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929

@nicain nicain Awaiting requested review from nicain nicain is a code owner automatically assigned from googleapis/python-samples-reviewers

@sycai sycai Awaiting requested review from sycai

Assignees

@shuoweil shuoweil

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shuoweil @GarrettWu @sycai