feat(scylladb): adding support for ScyllaDB source and tool by zseta · Pull Request #3119 · googleapis/mcp-toolbox

zseta · 2026-04-23T16:20:39Z

Description

Adds support for ScyllaDB source and tool using the ScyllaDB Go driver.

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

Make sure you reviewed
CONTRIBUTING.md
Make sure to open an issue as a
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Make sure to add ! if this involve a breaking change

🛠️ Fixes #3117

gemini-code-assist

Code Review

This pull request introduces support for ScyllaDB as a data source and provides a ScyllaDB CQL tool. It includes the necessary CI configuration, source and tool implementations, unit tests, and integration tests. Feedback focuses on improving JSON serialization consistency by initializing slices, adopting modern Go "any" syntax, enhancing error messages for query failures, and simplifying internal interfaces by removing unused methods.

zseta · 2026-04-30T10:21:25Z

hi @Yuan325 , can i get some guidance regarding this PR?

Yuan325

Hi @zseta Thank you for your contribution! Please let me know if you needs any clarifications on the feedback :)

zseta · 2026-05-07T13:38:49Z

Thanks for the comments @Yuan325 I resolved most of the issues. The only problem is with importing (#3119 (comment)). I hope it's not a blocker, if it is then we will need to wait for a fix on our end before merging this.

I also edited the integration test so it uses containers - couldn't run it though so please check.

Yuan325 · 2026-06-17T19:52:15Z

/gcbrun

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Yuan325 · 2026-06-17T20:13:12Z

/gcbrun

Yuan325 · 2026-06-17T20:16:34Z

/gcbrun

Yuan325 · 2026-06-17T20:16:49Z

/gcbrun

Yuan325 · 2026-06-17T21:03:16Z

Hi @zseta , this PR LGTM, thank you again for your contributions. However, it seems like the integration tests is currently failing.

Cluster warnings: [Tables in this keyspace will be replicated using Tablets and will not support CDC, LWT and counters features. To use CDC, LWT or counters, drop this keyspace and re-create it without tablets by adding AND TABLETS = {'enabled': false} to the CREATE KEYSPACE statement. Using Replication Factor replication_factor=1 lower than the minimum_replication_factor_warn_threshold=3 is not recommended.]
--
  | scylladb_integration_test.go:195: failed to create table: Table names shouldn't be more than 48 characters long (got "template_param_table_2db5d780a8114b2fb378eeaa3347fe13") (potentially executed: false)

I'll go ahead and merge this once resolved. Thank you again!

Yuan325 · 2026-06-17T21:38:29Z

/gcbrun

zseta · 2026-06-17T21:39:23Z

@Yuan325 I've fixed the issue i believe:

updated ScyllaDB version to use latest (which doesn't have the long table name issue)
Noticed there was an import issue as well, so fixed that too

Yuan325 · 2026-06-17T21:55:38Z

Hi @zseta it seems like the integration tests is still failing (feel free to test it locally to check if it pases--https://github.com/googleapis/mcp-toolbox/blob/main/DEVELOPER.md#integration-tests):


2026/06/17 21:45:24 Cluster warnings: [Using Replication Factor replication_factor=1 lower than the minimum_replication_factor_warn_threshold=3 is not recommended.]
--
  | scylladb_integration_test.go:217: toolbox command logs:
  | 2026-06-17T21:45:24.692645732Z INFO "Starting MCP Toolbox for Databases version 1.4.0+dev.linux.amd64"
  | scylladb_integration_test.go:218: toolbox didn't start successfully: context deadline exceeded

Also, can you please fix the lint failure? Thank you!

zseta · 2026-06-17T22:09:57Z

@Yuan325 Lint fixed. And i had all 39 subtests passed.

Yuan325 · 2026-06-17T22:28:42Z

/gcbrun

Yuan325

Thank you!

Yuan325 · 2026-06-17T22:44:13Z

/gcbrun

Yuan325 · 2026-06-17T23:29:17Z

/gcbrun

…3119) ## Description Adds support for ScyllaDB source and tool using the [ScyllaDB Go driver](https://github.com/scylladb/gocql). ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/mcp-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/mcp-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #3117 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> Co-authored-by: Yuan Teoh <yuanteoh@google.com> 2dada83

Yuan325 · 2026-06-18T00:06:59Z

@zseta Thank you again! :)

…oogleapis#3119) ## Description Adds support for ScyllaDB source and tool using the [ScyllaDB Go driver](https://github.com/scylladb/gocql). ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/mcp-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/mcp-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#3117 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> Co-authored-by: Yuan Teoh <yuanteoh@google.com> 2dada83

🤖 I have created a release *beep* *boop* --- ## [1.5.0](v1.4.0...v1.5.0) (2026-06-18) ### Features * **auth/google:** Require audience or clientId for mcpEnabled ([#3450](#3450)) ([59f7b6e](59f7b6e)) * Enable per source level flags for sql commenter ([#3465](#3465)) ([ecce6b7](ecce6b7)) * **mcp:** Add URL parameter binding for HTTP transport ([#3112](#3112)) ([0cc7b37](0cc7b37)) * **scylladb:** Adding support for ScyllaDB source and tool ([#3119](#3119)) ([2dada83](2dada83)) * **server:** Add support for toolset filtering in prebuilt CLI flag ([#3245](#3245)) ([7cc4f65](7cc4f65)) * **skills:** Generate skills offline without live source connections ([#3388](#3388)) ([4c860b6](4c860b6)) * **skills:** Tolerate missing env vars during offline skills-generate ([#3399](#3399)) ([ea5d3e5](ea5d3e5)) * **source/cloud-storage:** Restrict bucket and local path access ([#3454](#3454)) ([2c3ca5d](2c3ca5d)) * **tools/bigquery:** Add per tool query label in BigQuery jobs ([#1975](#1975)) ([3f6a49f](3f6a49f)) * **tools/dataplex:** Add tools to support metadata enrichment workflow ([#3270](#3270)) ([05289aa](05289aa)) * **tools/mysql:** Add show-query-stats and list-all-locks tools for MySQL and Cloud SQL MySQL source ([#2954](#2954)) ([a9693bd](a9693bd)) * **tools:** Decouple tool initialization from sources ([#3355](#3355)) ([32a24e3](32a24e3)) ### Bug Fixes * **auth/dataplex:** Fix failing source with service account credentials ([#3369](#3369)) ([ba4deef](ba4deef)) * **bigquery:** Wire maximumBytesBilled into prebuilt config ([#3385](#3385)) ([4abbf6e](4abbf6e)) * Bound MCP HTTP body size ([#3216](#3216)) ([d4f4342](d4f4342)) * **config:** Add doc/line context to parse errors ([#2957](#2957)) ([4b097da](4b097da)) * Escape delimiter characters in applyEscape to prevent SQL injection ([#2811](#2811)) ([932519a](932519a)) * **npm:** Source binary version from cmd/version.txt ([#3417](#3417)) ([6ffbdec](6ffbdec)) * **prebuilt/alloydb-omni:** Require password env var explicitly ([#3398](#3398)) ([fcbe3e7](fcbe3e7)) * **server:** Fail if MCP auth is enabled together with enable-api ([#3435](#3435)) ([a6ff910](a6ff910)) * **server:** Return errors instead of panicking in InitializeConfigs ([#3397](#3397)) ([f48b01d](f48b01d)) * **source/cloudhealthcare:** Validate pageURL parameter to prevent SSRF ([#3453](#3453)) ([9abf47d](9abf47d)) * **source/dataplex,source/datalineage:** Specify cloud-platform scope for default credentials ([#3376](#3376)) ([13e8c36](13e8c36)) * **source/http:** Implement SSRF guard ([#3448](#3448)) ([24d7d29](24d7d29)) * **tool/bigquery-execute-sql:** Prevent dataset restriction bypass ([#3452](#3452)) ([ca6d5e3](ca6d5e3)) * **tool/mysql-get-query-plan:** Prevent query execution bypass and statement injection ([#3235](#3235)) ([7ed1e7b](7ed1e7b)) * **tool/spanner-sql,tool/spanner-execute-sql:** Use read-only annotations when readOnly is set ([#3338](#3338)) ([8bde0ec](8bde0ec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [1.5.0](v1.4.0...v1.5.0) (2026-06-18) ### Features * **auth/google:** Require audience or clientId for mcpEnabled ([#3450](#3450)) ([59f7b6e](59f7b6e)) * Enable per source level flags for sql commenter ([#3465](#3465)) ([ecce6b7](ecce6b7)) * **mcp:** Add URL parameter binding for HTTP transport ([#3112](#3112)) ([0cc7b37](0cc7b37)) * **scylladb:** Adding support for ScyllaDB source and tool ([#3119](#3119)) ([2dada83](2dada83)) * **server:** Add support for toolset filtering in prebuilt CLI flag ([#3245](#3245)) ([7cc4f65](7cc4f65)) * **skills:** Generate skills offline without live source connections ([#3388](#3388)) ([4c860b6](4c860b6)) * **skills:** Tolerate missing env vars during offline skills-generate ([#3399](#3399)) ([ea5d3e5](ea5d3e5)) * **source/cloud-storage:** Restrict bucket and local path access ([#3454](#3454)) ([2c3ca5d](2c3ca5d)) * **tools/bigquery:** Add per tool query label in BigQuery jobs ([#1975](#1975)) ([3f6a49f](3f6a49f)) * **tools/dataplex:** Add tools to support metadata enrichment workflow ([#3270](#3270)) ([05289aa](05289aa)) * **tools/mysql:** Add show-query-stats and list-all-locks tools for MySQL and Cloud SQL MySQL source ([#2954](#2954)) ([a9693bd](a9693bd)) * **tools:** Decouple tool initialization from sources ([#3355](#3355)) ([32a24e3](32a24e3)) ### Bug Fixes * **auth/dataplex:** Fix failing source with service account credentials ([#3369](#3369)) ([ba4deef](ba4deef)) * **bigquery:** Wire maximumBytesBilled into prebuilt config ([#3385](#3385)) ([4abbf6e](4abbf6e)) * Bound MCP HTTP body size ([#3216](#3216)) ([d4f4342](d4f4342)) * **config:** Add doc/line context to parse errors ([#2957](#2957)) ([4b097da](4b097da)) * Escape delimiter characters in applyEscape to prevent SQL injection ([#2811](#2811)) ([932519a](932519a)) * **npm:** Source binary version from cmd/version.txt ([#3417](#3417)) ([6ffbdec](6ffbdec)) * **prebuilt/alloydb-omni:** Require password env var explicitly ([#3398](#3398)) ([fcbe3e7](fcbe3e7)) * **server:** Fail if MCP auth is enabled together with enable-api ([#3435](#3435)) ([a6ff910](a6ff910)) * **server:** Return errors instead of panicking in InitializeConfigs ([#3397](#3397)) ([f48b01d](f48b01d)) * **source/cloudhealthcare:** Validate pageURL parameter to prevent SSRF ([#3453](#3453)) ([9abf47d](9abf47d)) * **source/dataplex,source/datalineage:** Specify cloud-platform scope for default credentials ([#3376](#3376)) ([13e8c36](13e8c36)) * **source/http:** Implement SSRF guard ([#3448](#3448)) ([24d7d29](24d7d29)) * **tool/bigquery-execute-sql:** Prevent dataset restriction bypass ([#3452](#3452)) ([ca6d5e3](ca6d5e3)) * **tool/mysql-get-query-plan:** Prevent query execution bypass and statement injection ([#3235](#3235)) ([7ed1e7b](7ed1e7b)) * **tool/spanner-sql,tool/spanner-execute-sql:** Use read-only annotations when readOnly is set ([#3338](#3338)) ([8bde0ec](8bde0ec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 45c0f86

🤖 I have created a release *beep* *boop* --- ## [1.5.0](googleapis/mcp-toolbox@v1.4.0...v1.5.0) (2026-06-18) ### Features * **auth/google:** Require audience or clientId for mcpEnabled ([googleapis#3450](googleapis#3450)) ([59f7b6e](googleapis@59f7b6e)) * Enable per source level flags for sql commenter ([googleapis#3465](googleapis#3465)) ([ecce6b7](googleapis@ecce6b7)) * **mcp:** Add URL parameter binding for HTTP transport ([googleapis#3112](googleapis#3112)) ([0cc7b37](googleapis@0cc7b37)) * **scylladb:** Adding support for ScyllaDB source and tool ([googleapis#3119](googleapis#3119)) ([2dada83](googleapis@2dada83)) * **server:** Add support for toolset filtering in prebuilt CLI flag ([googleapis#3245](googleapis#3245)) ([7cc4f65](googleapis@7cc4f65)) * **skills:** Generate skills offline without live source connections ([googleapis#3388](googleapis#3388)) ([4c860b6](googleapis@4c860b6)) * **skills:** Tolerate missing env vars during offline skills-generate ([googleapis#3399](googleapis#3399)) ([ea5d3e5](googleapis@ea5d3e5)) * **source/cloud-storage:** Restrict bucket and local path access ([googleapis#3454](googleapis#3454)) ([2c3ca5d](googleapis@2c3ca5d)) * **tools/bigquery:** Add per tool query label in BigQuery jobs ([googleapis#1975](googleapis#1975)) ([3f6a49f](googleapis@3f6a49f)) * **tools/dataplex:** Add tools to support metadata enrichment workflow ([googleapis#3270](googleapis#3270)) ([05289aa](googleapis@05289aa)) * **tools/mysql:** Add show-query-stats and list-all-locks tools for MySQL and Cloud SQL MySQL source ([googleapis#2954](googleapis#2954)) ([a9693bd](googleapis@a9693bd)) * **tools:** Decouple tool initialization from sources ([googleapis#3355](googleapis#3355)) ([32a24e3](googleapis@32a24e3)) ### Bug Fixes * **auth/dataplex:** Fix failing source with service account credentials ([googleapis#3369](googleapis#3369)) ([ba4deef](googleapis@ba4deef)) * **bigquery:** Wire maximumBytesBilled into prebuilt config ([googleapis#3385](googleapis#3385)) ([4abbf6e](googleapis@4abbf6e)) * Bound MCP HTTP body size ([googleapis#3216](googleapis#3216)) ([d4f4342](googleapis@d4f4342)) * **config:** Add doc/line context to parse errors ([googleapis#2957](googleapis#2957)) ([4b097da](googleapis@4b097da)) * Escape delimiter characters in applyEscape to prevent SQL injection ([googleapis#2811](googleapis#2811)) ([932519a](googleapis@932519a)) * **npm:** Source binary version from cmd/version.txt ([googleapis#3417](googleapis#3417)) ([6ffbdec](googleapis@6ffbdec)) * **prebuilt/alloydb-omni:** Require password env var explicitly ([googleapis#3398](googleapis#3398)) ([fcbe3e7](googleapis@fcbe3e7)) * **server:** Fail if MCP auth is enabled together with enable-api ([googleapis#3435](googleapis#3435)) ([a6ff910](googleapis@a6ff910)) * **server:** Return errors instead of panicking in InitializeConfigs ([googleapis#3397](googleapis#3397)) ([f48b01d](googleapis@f48b01d)) * **source/cloudhealthcare:** Validate pageURL parameter to prevent SSRF ([googleapis#3453](googleapis#3453)) ([9abf47d](googleapis@9abf47d)) * **source/dataplex,source/datalineage:** Specify cloud-platform scope for default credentials ([googleapis#3376](googleapis#3376)) ([13e8c36](googleapis@13e8c36)) * **source/http:** Implement SSRF guard ([googleapis#3448](googleapis#3448)) ([24d7d29](googleapis@24d7d29)) * **tool/bigquery-execute-sql:** Prevent dataset restriction bypass ([googleapis#3452](googleapis#3452)) ([ca6d5e3](googleapis@ca6d5e3)) * **tool/mysql-get-query-plan:** Prevent query execution bypass and statement injection ([googleapis#3235](googleapis#3235)) ([7ed1e7b](googleapis@7ed1e7b)) * **tool/spanner-sql,tool/spanner-execute-sql:** Use read-only annotations when readOnly is set ([googleapis#3338](googleapis#3338)) ([8bde0ec](googleapis@8bde0ec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 45c0f86

gemini-code-assist Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread internal/sources/scylladb/scylladb.go

Comment thread internal/sources/scylladb/scylladb.go Outdated

Comment thread internal/tools/scylladb/scyllacql/scyllacql.go

Comment thread tests/scylladb/scylladb_integration_test.go Outdated

zseta marked this pull request as ready for review April 27, 2026 15:32

zseta requested a review from a team as a code owner April 27, 2026 15:32

blunderbuss-gcf Bot assigned Yuan325 Apr 27, 2026

Yuan325 changed the title ~~feat: Add ScyllaDB source and tool~~ feat(scylladb): adding support for ScyllaDB source and tool May 5, 2026

Yuan325 requested changes May 5, 2026

View reviewed changes

zseta requested a review from Yuan325 May 7, 2026 13:39

Yuan325 added the release candidate Use label to signal PR should be included in the next release. label Jun 17, 2026

zseta and others added 9 commits June 17, 2026 13:05

add scylladb source and tools

26fd085

add integration test

2411c99

add docs

6a2503c

more descriptive error message

dce1e7c

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update expected error message

b516ae4

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

fix copyright year

2da6413

Add ScyllaDB Testcontainers in integration tests

c8c89d8

Minor fixes

5612a5b

Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Add TLS configuration options for ScyllaDB connections

ed66321

Yuan325 force-pushed the feat-scylladb branch from 27e9fc6 to cec5fc9 Compare June 17, 2026 20:12

refactor tool and update .ci

9e3191f

Yuan325 force-pushed the feat-scylladb branch from cec5fc9 to 9e3191f Compare June 17, 2026 20:16

Yuan325 enabled auto-merge (squash) June 17, 2026 20:30

Yuan325 disabled auto-merge June 17, 2026 20:30

Fix import

6aec75e

zseta and others added 2 commits June 17, 2026 23:35

Fix version

dd9d69f

Merge branch 'main' into feat-scylladb

938b219

Linting fix

7d6e2cc

Disable host lookup on docker

06d6527

Merge branch 'main' into feat-scylladb

aecf936

Yuan325 approved these changes Jun 17, 2026

View reviewed changes

Merge branch 'main' into feat-scylladb

318a381

Yuan325 enabled auto-merge (squash) June 17, 2026 22:44

Merge branch 'main' into feat-scylladb

1779f47

Yuan325 merged commit 2dada83 into googleapis:main Jun 17, 2026
27 checks passed

release-please Bot mentioned this pull request Jun 17, 2026

chore(main): release 1.5.0 #3379

Merged

BrewTestBot mentioned this pull request Jun 18, 2026

mcp-toolbox 1.5.0 Homebrew/homebrew-core#288736

Merged

Uh oh!

Conversation

zseta commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

PR Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zseta commented Apr 30, 2026

Uh oh!

Yuan325 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zseta commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Yuan325 commented Jun 17, 2026

Uh oh!

Yuan325 commented Jun 17, 2026

Uh oh!

Yuan325 commented Jun 17, 2026

Uh oh!

Yuan325 commented Jun 17, 2026

Uh oh!

Yuan325 commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Yuan325 commented Jun 17, 2026

Uh oh!

zseta commented Jun 17, 2026

Uh oh!

Yuan325 commented Jun 17, 2026

Uh oh!

zseta commented Jun 17, 2026

Uh oh!

Yuan325 commented Jun 17, 2026

Uh oh!

Yuan325 left a comment

Choose a reason for hiding this comment

Uh oh!

Yuan325 commented Jun 17, 2026

Uh oh!

Yuan325 commented Jun 17, 2026

Uh oh!

Uh oh!

Yuan325 commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zseta commented Apr 23, 2026 •

edited

Loading

zseta commented May 7, 2026 •

edited

Loading

Yuan325 commented Jun 17, 2026 •

edited

Loading