Skip to content

fix: validate required common fields for parameters - #298

Merged
Yuan325 merged 3 commits into
mainfrom
validate-param
Feb 19, 2025
Merged

Yuan325 merged 3 commits into
mainfrom
validate-param

Conversation

@Yuan325

@Yuan325 Yuan325 commented Feb 18, 2025 •

Copy link
Copy Markdown
Contributor

Check common parameters for required fields. Throw an error if name or description is not provided.

Example of error when description field not provided:

2025-02-18T14:11:55.475101-08:00 ERROR "unable to parse tool file at \"tools.yaml\": unable to parse as \"postgres-sql\": unable to parse as \"array\": Key: 'CommonParameter.Desc' Error:Field validation for 'Desc' failed on the 'required' tag"

@Yuan325
Yuan325 marked this pull request as ready for review February 18, 2025 23:29
@Yuan325
Yuan325 requested a review from a team February 18, 2025 23:29
@Yuan325 Yuan325 changed the title chore: check common parameter for required fields chore: validate common parameter for required fields Feb 18, 2025
Base automatically changed from fix-items to main February 19, 2025 02:52
@kurtisvg kurtisvg changed the title chore: validate common parameter for required fields fix: validate required common fields for parameters Feb 19, 2025
@Yuan325
Yuan325 merged commit e494d11 into main Feb 19, 2025
@Yuan325
Yuan325 deleted the validate-param branch February 19, 2025 18:10
Yuan325 pushed a commit that referenced this pull request Mar 3, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](v0.1.0...v0.2.0)
(2025-03-03)


### ⚠ BREAKING CHANGES

* Rename "AuthSource" in favor of "AuthService"
([#297](#297))

### Features

* Rename "AuthSource" in favor of "AuthService"
([#297](#297))
([04cb5fb](04cb5fb))

### Bug Fixes

* Add items to parameter manifest
([#293](#293))
([541612d](541612d))
* **source/cloud-sql:** Correct user agents not being sent
([#306](#306))
([584c8ae](584c8ae))
* Throw error when items field is missing from array parameter
([#296](#296))
([9193836](9193836))
* Validate required common fields for parameters
([#298](#298))
([e494d11](e494d11))


### Miscellaneous Chores

* Release 0.2.0
([#314](#314))
([d7ccf73](d7ccf73))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
Check common parameters for required fields. Throw an error if name or
description is not provided.

Example of error when `description` field not provided:
```
2025-02-18T14:11:55.475101-08:00 ERROR "unable to parse tool file at \"tools.yaml\": unable to parse as \"postgres-sql\": unable to parse as \"array\": Key: 'CommonParameter.Desc' Error:Field validation for 'Desc' failed on the 'required' tag"
```
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](googleapis/mcp-toolbox@v0.1.0...v0.2.0)
(2025-03-03)


### ⚠ BREAKING CHANGES

* Rename "AuthSource" in favor of "AuthService"
([googleapis#297](googleapis#297))

### Features

* Rename "AuthSource" in favor of "AuthService"
([googleapis#297](googleapis#297))
([04cb5fb](googleapis@04cb5fb))

### Bug Fixes

* Add items to parameter manifest
([googleapis#293](googleapis#293))
([541612d](googleapis@541612d))
* **source/cloud-sql:** Correct user agents not being sent
([googleapis#306](googleapis#306))
([584c8ae](googleapis@584c8ae))
* Throw error when items field is missing from array parameter
([googleapis#296](googleapis#296))
([9193836](googleapis@9193836))
* Validate required common fields for parameters
([googleapis#298](googleapis#298))
([e494d11](googleapis@e494d11))


### Miscellaneous Chores

* Release 0.2.0
([googleapis#314](googleapis#314))
([d7ccf73](googleapis@d7ccf73))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
NightStack15 added a commit to NightStack15/googleapis-_-genai-toolbox that referenced this pull request Mar 20, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](googleapis/mcp-toolbox@v0.1.0...v0.2.0)
(2025-03-03)


### ⚠ BREAKING CHANGES

* Rename "AuthSource" in favor of "AuthService"
([#297](googleapis/mcp-toolbox#297))

### Features

* Rename "AuthSource" in favor of "AuthService"
([#297](googleapis/mcp-toolbox#297))
([04cb5fb](googleapis/mcp-toolbox@04cb5fb))

### Bug Fixes

* Add items to parameter manifest
([#293](googleapis/mcp-toolbox#293))
([541612d](googleapis/mcp-toolbox@541612d))
* **source/cloud-sql:** Correct user agents not being sent
([#306](googleapis/mcp-toolbox#306))
([584c8ae](googleapis/mcp-toolbox@584c8ae))
* Throw error when items field is missing from array parameter
([#296](googleapis/mcp-toolbox#296))
([9193836](googleapis/mcp-toolbox@9193836))
* Validate required common fields for parameters
([#298](googleapis/mcp-toolbox#298))
([e494d11](googleapis/mcp-toolbox@e494d11))


### Miscellaneous Chores

* Release 0.2.0
([#314](googleapis/mcp-toolbox#314))
([d7ccf73](googleapis/mcp-toolbox@d7ccf73))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants