Skip to content

feat: Added Neo4j Source and Tool - #189

Merged
kurtisvg merged 8 commits into
googleapis:mainfrom
jexp:main
Jan 14, 2025
Merged

kurtisvg merged 8 commits into
googleapis:mainfrom
jexp:main

Conversation

@jexp

@jexp jexp commented Jan 7, 2025

Copy link
Copy Markdown
Contributor
  • configure neo4j source with url, username, password, database
  • configure neo4j tools with cypher statement and paramters
  • tests based on the postgres tests
  • neo4j.yaml for integration tests

@jexp
jexp requested a review from a team January 7, 2025 13:33
@jexp jexp mentioned this pull request Jan 7, 2025
3 of 5 tasks
@google-cla

google-cla Bot commented Jan 7, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kurtisvg

kurtisvg commented Jan 10, 2025 •

Copy link
Copy Markdown
Collaborator

@duwenxin99 the lint is failing on this because of repo permissions - can you make sure you run manually before we import it in?

@duwenxin99 duwenxin99 changed the title Added Neo4j Source and Tool feat: Added Neo4j Source and Tool Jan 14, 2025
jexp and others added 6 commits January 14, 2025 16:37
- configure neo4j source with url, username, password, database
- configure neo4j tools with cypher statement and paramters
- tests based on the postgres tests
- neo4j.yaml for integration tests

@duwenxin99 duwenxin99 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the PR:

  1. Added neo4j test config to the Cloud Build yaml file.
  2. Rebased on the latest change and added tracer to Neo4j source initialization.
  3. Deleted neo4j.yaml file.
  4. Ran golangci-lint and fixed format.

@kurtisvg
kurtisvg merged commit 8a1224b into googleapis:main Jan 14, 2025
@jexp

jexp commented Jan 14, 2025

Copy link
Copy Markdown
Contributor Author

Awesome, thank you all so much !!!

duwenxin99 pushed a commit that referenced this pull request Jan 14, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.0.5](v0.0.4...v0.0.5)
(2025-01-14)


### ⚠ BREAKING CHANGES

* replace Source field `ip_type` with `ipType` for consistency
([#197](#197))
* **toolbox-sdk:** deprecate 'add_auth_headers' in favor of
'add_auth_tokens'
([#170](#170))

### Features

* Add support for OpenTelemetry
([#205](#205))
([1fcc20a](1fcc20a))
* Added Neo4j Source and Tool
([#189](#189))
([8a1224b](8a1224b))
* **llamaindex-sdk:** Implement OAuth support for LlamaIndex.
([#159](#159))
([003ce51](003ce51))
* Replace Source field `ip_type` with `ipType` for consistency
([#197](#197))
([e069520](e069520))
* Update log with given context
([#147](#147))
([809e547](809e547))


### Bug Fixes

* Correct parsing of floats/ints from json
([#180](#180))
([387a5b5](387a5b5))
* **doc:** Update example `clientId` field
([#198](#198))
([0c86e89](0c86e89))
* Fix config name in auth doc samples
([#186](#186))
([bb03457](bb03457))
* Handle shutdown gracefully
([#178](#178))
([66ab70f](66ab70f))
* Improve return error for parameters
([#206](#206))
([346c57d](346c57d))
* **toolbox-sdk:** Deprecate 'add_auth_headers' in favor of
'add_auth_tokens'
([#170](#170))
([b56fa68](b56fa68))


### Miscellaneous Chores

* Release 0.0.5
([#210](#210))
([bd407c0](bd407c0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
…oogleapis#189)

I had this type of exception in my local sources while running this ADK example

INFO:common.server.task_manager:Upserting task b7ebdb35-a1ad-4b57-920e-4112b69b2a50
ERROR:task_manager:Error invoking agent: 'generator' object is not subscriptable
ERROR:common.server.server:Unhandled exception: Error invoking agent: 'generator' object is not subscriptable
INFO:     ::1:60297 - "POST / HTTP/1.1" 400 Bad Request

And actually the run method signature is

def run(
      self,
      *,
      user_id: str,
      session_id: str,
      new_message: types.Content,
      run_config: RunConfig = RunConfig(),
  ) -> Generator[Event, None, None]:

So it returns the Generator object which is not subscriptable as it is trying to be in this code example

Fix me if there is a easier solution but this approach helped me to run E2E implementation with my custom UI in TypeScript and agent made with Python
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
- configure neo4j source with url, username, password, database
- configure neo4j tools with cypher statement and paramters
- tests based on the postgres tests
- neo4j.yaml for integration tests
---------

Co-authored-by: duwenxin <duwenxin@google.com>
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.0.5](googleapis/mcp-toolbox@v0.0.4...v0.0.5)
(2025-01-14)


### ⚠ BREAKING CHANGES

* replace Source field `ip_type` with `ipType` for consistency
([googleapis#197](googleapis#197))
* **toolbox-sdk:** deprecate 'add_auth_headers' in favor of
'add_auth_tokens'
([googleapis#170](googleapis#170))

### Features

* Add support for OpenTelemetry
([googleapis#205](googleapis#205))
([1fcc20a](googleapis@1fcc20a))
* Added Neo4j Source and Tool
([googleapis#189](googleapis#189))
([8a1224b](googleapis@8a1224b))
* **llamaindex-sdk:** Implement OAuth support for LlamaIndex.
([googleapis#159](googleapis#159))
([003ce51](googleapis@003ce51))
* Replace Source field `ip_type` with `ipType` for consistency
([googleapis#197](googleapis#197))
([e069520](googleapis@e069520))
* Update log with given context
([googleapis#147](googleapis#147))
([809e547](googleapis@809e547))


### Bug Fixes

* Correct parsing of floats/ints from json
([googleapis#180](googleapis#180))
([387a5b5](googleapis@387a5b5))
* **doc:** Update example `clientId` field
([googleapis#198](googleapis#198))
([0c86e89](googleapis@0c86e89))
* Fix config name in auth doc samples
([googleapis#186](googleapis#186))
([bb03457](googleapis@bb03457))
* Handle shutdown gracefully
([googleapis#178](googleapis#178))
([66ab70f](googleapis@66ab70f))
* Improve return error for parameters
([googleapis#206](googleapis#206))
([346c57d](googleapis@346c57d))
* **toolbox-sdk:** Deprecate 'add_auth_headers' in favor of
'add_auth_tokens'
([googleapis#170](googleapis#170))
([b56fa68](googleapis@b56fa68))


### Miscellaneous Chores

* Release 0.0.5
([googleapis#210](googleapis#210))
([bd407c0](googleapis@bd407c0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
NightStack15 added a commit to NightStack15/googleapis-_-genai-toolbox that referenced this pull request Mar 20, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.0.5](googleapis/mcp-toolbox@v0.0.4...v0.0.5)
(2025-01-14)


### ⚠ BREAKING CHANGES

* replace Source field `ip_type` with `ipType` for consistency
([#197](googleapis/mcp-toolbox#197))
* **toolbox-sdk:** deprecate 'add_auth_headers' in favor of
'add_auth_tokens'
([#170](googleapis/mcp-toolbox#170))

### Features

* Add support for OpenTelemetry
([#205](googleapis/mcp-toolbox#205))
([1fcc20a](googleapis/mcp-toolbox@1fcc20a))
* Added Neo4j Source and Tool
([#189](googleapis/mcp-toolbox#189))
([8a1224b](googleapis/mcp-toolbox@8a1224b))
* **llamaindex-sdk:** Implement OAuth support for LlamaIndex.
([#159](googleapis/mcp-toolbox#159))
([003ce51](googleapis/mcp-toolbox@003ce51))
* Replace Source field `ip_type` with `ipType` for consistency
([#197](googleapis/mcp-toolbox#197))
([e069520](googleapis/mcp-toolbox@e069520))
* Update log with given context
([#147](googleapis/mcp-toolbox#147))
([809e547](googleapis/mcp-toolbox@809e547))


### Bug Fixes

* Correct parsing of floats/ints from json
([#180](googleapis/mcp-toolbox#180))
([387a5b5](googleapis/mcp-toolbox@387a5b5))
* **doc:** Update example `clientId` field
([#198](googleapis/mcp-toolbox#198))
([0c86e89](googleapis/mcp-toolbox@0c86e89))
* Fix config name in auth doc samples
([#186](googleapis/mcp-toolbox#186))
([bb03457](googleapis/mcp-toolbox@bb03457))
* Handle shutdown gracefully
([#178](googleapis/mcp-toolbox#178))
([66ab70f](googleapis/mcp-toolbox@66ab70f))
* Improve return error for parameters
([#206](googleapis/mcp-toolbox#206))
([346c57d](googleapis/mcp-toolbox@346c57d))
* **toolbox-sdk:** Deprecate 'add_auth_headers' in favor of
'add_auth_tokens'
([#170](googleapis/mcp-toolbox#170))
([b56fa68](googleapis/mcp-toolbox@b56fa68))


### Miscellaneous Chores

* Release 0.0.5
([#210](googleapis/mcp-toolbox#210))
([bd407c0](googleapis/mcp-toolbox@bd407c0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants