Skip to content

feat: add initial cloud sql pg invocation - #14

Merged
kurtisvg merged 1 commit into
mainfrom
tool-exec
Oct 15, 2024
Merged

feat: add initial cloud sql pg invocation#14
kurtisvg merged 1 commit into
mainfrom
tool-exec

Conversation

@kurtisvg

@kurtisvg kurtisvg commented Oct 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Makes the following changes:

  • Fills in previously stubbed "Invoke()" function for the Cloud SQL Generic Tool
  • Updates API to /{tool_name}/invoke to for invocation of said tool
  • Updates response to use JSON
  • Correctly returns error messages for invalid http codes

@kurtisvg
kurtisvg requested review from a team, Yuan325 and duwenxin99 October 13, 2024 21:56
Yuan325
Yuan325 reviewed Oct 14, 2024
View reviewed changes
Comment thread internal/sources/cloud_sql_pg.go
}

// Create a new dialer with any options
d, err := cloudsqlconn.NewDialer(context.Background())

@Yuan325 Yuan325 Oct 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the automatic IAM database authentication feature? (https://pkg.go.dev/cloud.google.com/go/cloudsqlconn#readme-automatic-iam-database-authentication, https://cloud.google.com/sql/docs/postgres/iam-authentication#auto-iam-auth) That way, users need to pass only the IAM database username in a connection request from the client. Seems like it will be more secure and reliable (also it will handle auth access tokens refresh auth access).

@kurtisvg kurtisvg Oct 15, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but planning to add in a separate PR. The IAM Auth is more complicated for Go than Python because of the lack of the email in the credentials source. This PR was already sizable so I will follow up on that in another PR.

@kurtisvg
kurtisvg requested a review from Yuan325 October 15, 2024 15:32
@kurtisvg
kurtisvg merged commit 3703176 into main Oct 15, 2024
@kurtisvg
kurtisvg deleted the tool-exec branch October 15, 2024 15:53
@release-please release-please Bot mentioned this pull request Oct 15, 2024
Merged
kurtisvg pushed a commit that referenced this pull request Oct 28, 2024
@release-please
chore(main): release 0.0.1 (#16)
7e8b870 
🤖 I have created a release *beep* *boop*
---


## 0.0.1 (2024-10-28)


### Features

* Add address and port flags
([#7](#7))
([df9ad9e](df9ad9e))
* Add AlloyDB source and tool
([#23](#23))
([fe92d02](fe92d02))
* Add basic CLI
([#5](#5))
([1539ee5](1539ee5))
* Add basic http server
([#6](#6))
([e09ae30](e09ae30))
* Add basic parsing from tools file
([#8](#8))
([b9ba364](b9ba364))
* Add initial cloud sql pg invocation
([#14](#14))
([3703176](3703176))
* Add Postgres source and tool
([#25](#25))
([2742ed4](2742ed4))
* Add preliminary parsing of parameters
([#13](#13))
([27edd3b](27edd3b))
* Add support for array type parameters
([#26](#26))
([3903e86](3903e86))
* Add toolset configuration
([#12](#12))
([59b4bc0](59b4bc0))
* Add Toolset manifest endpoint
([#11](#11))
([61e7b78](61e7b78))
* **langchain-sdk:** Add Toolbox SDK for LangChain
([#22](#22))
([0bcd4b6](0bcd4b6))
* Stub basic control plane functionality
([#9](#9))
([336bdc4](336bdc4))


### Miscellaneous Chores

* Release 0.0.1
([#31](#31))
([1f24ddd](1f24ddd))


### Continuous Integration

* Add realease-please
([#15](#15))
([17fbbb4](17fbbb4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Yuan325 pushed a commit that referenced this pull request Oct 29, 2024
@release-please @Yuan325
chore(main): release 0.0.1 (#16)
0b9b9fb 
🤖 I have created a release *beep* *boop*
---

* Add address and port flags
([#7](#7))
([df9ad9e](df9ad9e))
* Add AlloyDB source and tool
([#23](#23))
([fe92d02](fe92d02))
* Add basic CLI
([#5](#5))
([1539ee5](1539ee5))
* Add basic http server
([#6](#6))
([e09ae30](e09ae30))
* Add basic parsing from tools file
([#8](#8))
([b9ba364](b9ba364))
* Add initial cloud sql pg invocation
([#14](#14))
([3703176](3703176))
* Add Postgres source and tool
([#25](#25))
([2742ed4](2742ed4))
* Add preliminary parsing of parameters
([#13](#13))
([27edd3b](27edd3b))
* Add support for array type parameters
([#26](#26))
([3903e86](3903e86))
* Add toolset configuration
([#12](#12))
([59b4bc0](59b4bc0))
* Add Toolset manifest endpoint
([#11](#11))
([61e7b78](61e7b78))
* **langchain-sdk:** Add Toolbox SDK for LangChain
([#22](#22))
([0bcd4b6](0bcd4b6))
* Stub basic control plane functionality
([#9](#9))
([336bdc4](336bdc4))

* Release 0.0.1
([#31](#31))
([1f24ddd](1f24ddd))

* Add realease-please
([#15](#15))
([17fbbb4](17fbbb4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
@kurtisvg @jeffreyrubi
feat: add initial cloud sql pg invocation (googleapis#14)
e1a30cf 
Makes the following changes:
- Fills in previously stubbed "Invoke()" function for the Cloud SQL
Generic Tool
- Updates API to /{tool_name}/invoke to for invocation of said tool 
- Updates response to use JSON 
- Correctly returns error messages for invalid http codes
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
@release-please @jeffreyrubi
chore(main): release 0.0.1 (googleapis#16)
87e4b5b 
🤖 I have created a release *beep* *boop*
---


## 0.0.1 (2024-10-28)


### Features

* Add address and port flags
([googleapis#7](googleapis#7))
([df9ad9e](googleapis@df9ad9e))
* Add AlloyDB source and tool
([googleapis#23](googleapis#23))
([fe92d02](googleapis@fe92d02))
* Add basic CLI
([googleapis#5](googleapis#5))
([1539ee5](googleapis@1539ee5))
* Add basic http server
([googleapis#6](googleapis#6))
([e09ae30](googleapis@e09ae30))
* Add basic parsing from tools file
([googleapis#8](googleapis#8))
([b9ba364](googleapis@b9ba364))
* Add initial cloud sql pg invocation
([googleapis#14](googleapis#14))
([3703176](googleapis@3703176))
* Add Postgres source and tool
([googleapis#25](googleapis#25))
([2742ed4](googleapis@2742ed4))
* Add preliminary parsing of parameters
([googleapis#13](googleapis#13))
([27edd3b](googleapis@27edd3b))
* Add support for array type parameters
([googleapis#26](googleapis#26))
([3903e86](googleapis@3903e86))
* Add toolset configuration
([googleapis#12](googleapis#12))
([59b4bc0](googleapis@59b4bc0))
* Add Toolset manifest endpoint
([googleapis#11](googleapis#11))
([61e7b78](googleapis@61e7b78))
* **langchain-sdk:** Add Toolbox SDK for LangChain
([googleapis#22](googleapis#22))
([0bcd4b6](googleapis@0bcd4b6))
* Stub basic control plane functionality
([googleapis#9](googleapis#9))
([336bdc4](googleapis@336bdc4))


### Miscellaneous Chores

* Release 0.0.1
([googleapis#31](googleapis#31))
([1f24ddd](googleapis@1f24ddd))


### Continuous Integration

* Add realease-please
([googleapis#15](googleapis#15))
([17fbbb4](googleapis@17fbbb4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
@release-please @jeffreyrubi
chore(main): release 0.0.1 (googleapis#16)
e90bcb0 
🤖 I have created a release *beep* *boop*
---


## 0.0.1 (2024-10-28)


### Features

* Add address and port flags
([googleapis#7](googleapis#7))
([df9ad9e](googleapis@df9ad9e))
* Add AlloyDB source and tool
([googleapis#23](googleapis#23))
([fe92d02](googleapis@fe92d02))
* Add basic CLI
([googleapis#5](googleapis#5))
([1539ee5](googleapis@1539ee5))
* Add basic http server
([googleapis#6](googleapis#6))
([e09ae30](googleapis@e09ae30))
* Add basic parsing from tools file
([googleapis#8](googleapis#8))
([b9ba364](googleapis@b9ba364))
* Add initial cloud sql pg invocation
([googleapis#14](googleapis#14))
([3703176](googleapis@3703176))
* Add Postgres source and tool
([googleapis#25](googleapis#25))
([2742ed4](googleapis@2742ed4))
* Add preliminary parsing of parameters
([googleapis#13](googleapis#13))
([27edd3b](googleapis@27edd3b))
* Add support for array type parameters
([googleapis#26](googleapis#26))
([3903e86](googleapis@3903e86))
* Add toolset configuration
([googleapis#12](googleapis#12))
([59b4bc0](googleapis@59b4bc0))
* Add Toolset manifest endpoint
([googleapis#11](googleapis#11))
([61e7b78](googleapis@61e7b78))
* **langchain-sdk:** Add Toolbox SDK for LangChain
([googleapis#22](googleapis#22))
([0bcd4b6](googleapis@0bcd4b6))
* Stub basic control plane functionality
([googleapis#9](googleapis#9))
([336bdc4](googleapis@336bdc4))


### Miscellaneous Chores

* Release 0.0.1
([googleapis#31](googleapis#31))
([1f24ddd](googleapis@1f24ddd))


### Continuous Integration

* Add realease-please
([googleapis#15](googleapis#15))
([17fbbb4](googleapis@17fbbb4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This was referenced Feb 18, 2026
Closed
Closed
Closed
Closed
Open
Open
@github-actions github-actions Bot mentioned this pull request Mar 4, 2026
Merged
NightStack15 added a commit to NightStack15/googleapis-_-genai-toolbox that referenced this pull request Mar 20, 2026
@NightStack15 @release-please
chore(main): release 0.0.1 (#16)
86becb7 
🤖 I have created a release *beep* *boop*
---


## 0.0.1 (2024-10-28)


### Features

* Add address and port flags
([#7](googleapis/mcp-toolbox#7))
([df9ad9e](googleapis/mcp-toolbox@df9ad9e))
* Add AlloyDB source and tool
([#23](googleapis/mcp-toolbox#23))
([fe92d02](googleapis/mcp-toolbox@fe92d02))
* Add basic CLI
([#5](googleapis/mcp-toolbox#5))
([1539ee5](googleapis/mcp-toolbox@1539ee5))
* Add basic http server
([#6](googleapis/mcp-toolbox#6))
([e09ae30](googleapis/mcp-toolbox@e09ae30))
* Add basic parsing from tools file
([#8](googleapis/mcp-toolbox#8))
([b9ba364](googleapis/mcp-toolbox@b9ba364))
* Add initial cloud sql pg invocation
([#14](googleapis/mcp-toolbox#14))
([3703176](googleapis/mcp-toolbox@3703176))
* Add Postgres source and tool
([#25](googleapis/mcp-toolbox#25))
([2742ed4](googleapis/mcp-toolbox@2742ed4))
* Add preliminary parsing of parameters
([#13](googleapis/mcp-toolbox#13))
([27edd3b](googleapis/mcp-toolbox@27edd3b))
* Add support for array type parameters
([#26](googleapis/mcp-toolbox#26))
([3903e86](googleapis/mcp-toolbox@3903e86))
* Add toolset configuration
([#12](googleapis/mcp-toolbox#12))
([59b4bc0](googleapis/mcp-toolbox@59b4bc0))
* Add Toolset manifest endpoint
([#11](googleapis/mcp-toolbox#11))
([61e7b78](googleapis/mcp-toolbox@61e7b78))
* **langchain-sdk:** Add Toolbox SDK for LangChain
([#22](googleapis/mcp-toolbox#22))
([0bcd4b6](googleapis/mcp-toolbox@0bcd4b6))
* Stub basic control plane functionality
([#9](googleapis/mcp-toolbox#9))
([336bdc4](googleapis/mcp-toolbox@336bdc4))


### Miscellaneous Chores

* Release 0.0.1
([#31](googleapis/mcp-toolbox#31))
([1f24ddd](googleapis/mcp-toolbox@1f24ddd))


### Continuous Integration

* Add realease-please
([#15](googleapis/mcp-toolbox#15))
([17fbbb4](googleapis/mcp-toolbox@17fbbb4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yuan325 Yuan325 Yuan325 approved these changes
@duwenxin99 duwenxin99 Awaiting requested review from duwenxin99

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kurtisvg @Yuan325