Skip to content

docs(samples): add storage_grpc_quickstart samples#2041

Merged
BenWhitehead merged 6 commits into
mainfrom
samples/grpc
Jun 22, 2023
Merged

docs(samples): add storage_grpc_quickstart samples#2041
BenWhitehead merged 6 commits into
mainfrom
samples/grpc

Conversation

@BenWhitehead

@BenWhitehead BenWhitehead commented May 31, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@snippet-bot

snippet-bot Bot commented May 31, 2023 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels May 31, 2023
@BenWhitehead
BenWhitehead force-pushed the samples/grpc branch 2 times, most recently from 635d4bc to fc79b30 Compare May 31, 2023 15:50
@gcf-owl-bot
gcf-owl-bot Bot requested review from a team May 31, 2023 15:53
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 31, 2023
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 31, 2023
frankyn
frankyn reviewed May 31, 2023
View reviewed changes
Comment thread samples/snippets/src/main/java/com/example/storage/QuickstartGrpcSample.java Outdated
tritone
tritone reviewed Jun 1, 2023
View reviewed changes
Comment thread samples/snippets/src/main/java/com/example/storage/QuickstartGrpcSample.java Outdated
Comment thread samples/snippets/src/test/java/com/example/storage/QuickstartGrpcSampleIT.java Outdated
Comment thread samples/snippets/src/main/java/com/example/storage/QuickstartGrpcSample.java Outdated
frankyn
frankyn reviewed Jun 2, 2023
View reviewed changes
Comment thread samples/snippets/src/main/java/com/example/storage/QuickstartGrpcSample.java
frankyn
frankyn reviewed Jun 22, 2023
View reviewed changes

@frankyn frankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one last comment from my side

Comment thread samples/snippets/src/main/java/com/example/storage/QuickstartGrpcDpSample.java
tritone
tritone approved these changes Jun 22, 2023
View reviewed changes

@tritone tritone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some comment things, otherwise LGTM

Comment thread samples/snippets/src/main/java/com/example/storage/QuickstartGrpcDpSample.java
Comment thread samples/snippets/src/main/java/com/example/storage/QuickstartGrpcDpSample.java Outdated
@BenWhitehead BenWhitehead changed the title docs(samples): add storage_quickstart_grpc sample docs(samples): add storage_grpc_quickstart samples Jun 22, 2023
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@BenWhitehead BenWhitehead added the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2023
@BenWhitehead
BenWhitehead merged commit 5f916fb into main Jun 22, 2023
@BenWhitehead
BenWhitehead deleted the samples/grpc branch June 22, 2023 22:17
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2023
@release-please release-please Bot mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@frankyn frankyn frankyn left review comments
@tritone tritone tritone approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@anguillanneuf anguillanneuf

Labels

api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

Storage gRPC implementation

Development

Successfully merging this pull request may close these issues.

5 participants

@BenWhitehead @frankyn @tritone @anguillanneuf @yoshi-kokoro