Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

docs(samples): add iam deny samples and test - #371

Merged
Sita04 merged 13 commits into
mainfrom
deny-samples
Jul 8, 2022
Merged

docs(samples): add iam deny samples and test#371
Sita04 merged 13 commits into
mainfrom
deny-samples

Conversation

@Sita04

@Sita04 Sita04 commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

Added samples and tests for IAM Deny launch.

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: iam Issues related to the googleapis/java-iam API. samples Issues that are directly related to samples. labels Jun 30, 2022
@Sita04 Sita04 added owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 30, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 30, 2022
@Sita04
Sita04 marked this pull request as ready for review July 5, 2022 05:28
@Sita04
Sita04 requested a review from a team July 5, 2022 05:28
@Sita04 Sita04 added the blunderbuss: assign Instruct blunderbuss to assign someone label Jul 6, 2022
@blunderbuss-gcf blunderbuss-gcf Bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Jul 6, 2022
@snippet-bot

snippet-bot Bot commented Jul 6, 2022 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

kurtisvg
kurtisvg approved these changes Jul 6, 2022
View reviewed changes

@kurtisvg kurtisvg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

hegemonic
hegemonic suggested changes Jul 6, 2022
View reviewed changes

@hegemonic hegemonic left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Most of these comments are very minor.

Comment thread samples/cloud-client/snippets/src/main/java/CreateDenyPolicy.java Outdated
Comment thread samples/cloud-client/snippets/src/main/java/CreateDenyPolicy.java Outdated
Comment thread samples/cloud-client/snippets/src/main/java/CreateDenyPolicy.java Outdated
Comment thread samples/cloud-client/snippets/src/main/java/CreateDenyPolicy.java Outdated
Comment thread samples/cloud-client/snippets/src/main/java/CreateDenyPolicy.java Outdated
Comment thread samples/cloud-client/snippets/src/main/java/UpdateDenyPolicy.java Outdated
Comment thread samples/cloud-client/snippets/src/main/java/UpdateDenyPolicy.java Outdated
Comment thread samples/cloud-client/snippets/src/main/java/UpdateDenyPolicy.java Outdated
Comment thread samples/cloud-client/snippets/src/main/java/UpdateDenyPolicy.java Outdated
Comment thread samples/cloud-client/snippets/src/main/java/UpdateDenyPolicy.java Outdated
@Sita04

Sita04 commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

@hegemonic PTAL.

hegemonic
hegemonic approved these changes Jul 7, 2022
View reviewed changes

@hegemonic hegemonic left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Sita—thank you!

@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2022
@Sita04
Sita04 merged commit c503444 into main Jul 8, 2022
@Sita04
Sita04 deleted the deny-samples branch July 8, 2022 06:59
@release-please release-please Bot mentioned this pull request Jul 8, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@hegemonic hegemonic hegemonic approved these changes
@kurtisvg kurtisvg kurtisvg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kurtisvg kurtisvg

Labels

api: iam Issues related to the googleapis/java-iam API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sita04 @hegemonic @kurtisvg @yoshi-kokoro