feat: adding gcp resource name span attribute #2260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Gautam04 Did you have someone in mind to review this PR? |
Contributor
|
Googlers see b/437960147 and g/firestore-sdk-team/c/uvdOjkrQ2Ns/m/1wJrFyFdAwAJ for some background details |
Author
No, |
Contributor
I've added @wu-hui and @MarkDuckworth as reviewers, this this PR and googleapis/nodejs-firestore#2454 |
google-cloud-firestore/src/main/java/com/google/cloud/firestore/telemetry/TraceUtil.java
Show resolved
Hide resolved
MarkDuckworth
approved these changes
Dec 8, 2025
google-cloud-firestore/src/main/java/com/google/cloud/firestore/telemetry/TraceUtil.java
Show resolved
Hide resolved
Author
|
@wu-hui Could you please check this PR? |
wu-hui
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new span attribute called
gcp.resource.namewhich contains an identifier to a particular firestore database in the following format:Example: