Skip to content

test: Add integration tests for picosecond support #4030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
lqiu96 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test: Add integration tests for picosecond support #4030

lqiu96 wants to merge 2 commits into from

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Dec 12, 2025

No description provided.

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/java-bigquery API. labels Dec 12, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 12, 2025

Summary of Changes

Hello @lqiu96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds comprehensive integration tests to verify BigQuery's functionality with picosecond precision timestamps. The tests ensure that high-precision timestamps can be correctly inserted, queried, and used with named parameters, covering both valid and invalid data formats. A minor adjustment was also made to the RemoteBigQueryHelper to facilitate the custom BigQuery client configurations required for these new tests.

Highlights

  • New Integration Tests: Introduced a new integration test suite (ITHighPrecisionTimestamp.java) specifically designed to validate BigQuery's support for picosecond precision timestamps.
  • Enhanced Test Helper: Modified RemoteBigQueryHelper.java to allow for custom BigQueryOptions.Builder configurations, enabling more flexible setup of BigQuery clients for testing specific features like high-precision timestamps.
  • Timestamp Precision Validation: The new tests cover various scenarios including querying, inserting, and using named parameters with picosecond precision timestamps, as well as validating expected failures for invalid timestamp formats and missing explicit casts in queries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 12, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces integration tests for picosecond precision timestamp support in BigQuery. The changes involve a refactoring of RemoteBigQueryHelper to facilitate custom BigQueryOptions for testing purposes, and the addition of a new test class ITHighPrecisionTimestamp. The new tests are thorough, covering various scenarios for inserting and querying high-precision timestamps. My review includes a suggestion to remove a leftover debug statement and a couple of minor improvements in the new test file for better code style and correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lqiu96