test: update protobuf runtime to 4.33.0 #4020
Conversation
Summary of ChangesHello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine maintenance update by bumping the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to update the protobuf runtime version. It does so by adding com.google.protobuf:protobuf-bom to the parent pom.xml's dependencyManagement. While centralizing dependency versions is a good practice, the current implementation has a critical issue: it attempts to use version 4.33.0 of a BOM that does not exist for Protobuf 4.x versions, which will break the build. My review provides details on why this approach is incorrect and suggests an alternative strategy for managing Protobuf 4.x dependencies.
| <dependency> | ||
| <groupId>com.google.protobuf</groupId> | ||
| <artifactId>protobuf-bom</artifactId> | ||
| <version>4.33.0</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> |
There was a problem hiding this comment.
This change introduces protobuf-bom with version 4.33.0, but this approach seems incorrect for managing Protobuf 4.x dependencies for two main reasons:
- Non-existent Version: The version
4.33.0forcom.google.protobuf:protobuf-bomdoes not exist in public Maven repositories. This will cause the build to fail. - No BOM for Protobuf 4.x: The
com.google.protobuf:protobuf-bomartifact is only published for3.xversions of Protobuf. For4.xversions (e.g., the4.26.xreleases ofprotobuf-java), a BOM is not provided by the Protobuf team.
If the goal is to upgrade to a 4.x version of Protobuf, you will need to manage the versions of individual protobuf-* artifacts directly, likely using a Maven property. Simply importing this BOM will not work.
Please revise the dependency management strategy for Protobuf.
No description provided.