Skip to content

chore: disable flaky tests #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
diegomarquezp wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: disable flaky tests #4016

diegomarquezp wants to merge 3 commits into from

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Dec 8, 2025 •
edited
Loading

See each disabled test for the associated internal tracker.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Dec 8, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 8, 2025

Summary of Changes

Hello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses persistent flakiness in the continuous integration pipeline by disabling a set of problematic integration tests. This involves both programmatic exclusion of tests during the GraalVM native image build and marking specific JUnit tests within the BigQuery test suite with an @Ignore annotation. The primary goal is to stabilize CI runs and prevent false negatives caused by unreliable tests, allowing for a clearer signal on actual code regressions.

Highlights

  • GraalVM Test Exclusions: Several BigQuery integration tests are now explicitly excluded from the GraalVM native image build process in the .kokoro/build.sh script to prevent build failures due to flakiness. This is achieved by dynamically constructing a list of tests to skip using the -Dtest Maven parameter.
  • JUnit Test Ignoring: Three specific BigQuery integration tests (testLocationFastSQLQueryWithJobId, testTableResultJobIdAndQueryId, testQueryWithTimeout) have been marked with @Ignore annotations in ITBigQueryTest.java to temporarily disable them due to identified flakiness, each with a corresponding bug ID.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Dec 8, 2025 •
edited
Loading

@gemini-code-assist review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables several flaky tests. Some tests are disabled for all test runs using JUnit's @Ignore annotation, while others are excluded specifically for GraalVM builds via a shell script modification. The changes are straightforward and address the flakiness. I've provided one suggestion to improve the shell script's conciseness and make it more idiomatic.

@diegomarquezp diegomarquezp marked this pull request as ready for review December 8, 2025 18:57
@diegomarquezp diegomarquezp requested review from a team as code owners December 8, 2025 18:57
@diegomarquezp diegomarquezp requested review from jinseopkim0 and mrfaizal and removed request for mrfaizal December 8, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinseopkim0 jinseopkim0 Awaiting requested review from jinseopkim0

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@diegomarquezp