Skip to content

#825: Allow passing explicit connection to 'Bucket.{list_blobs,make public}'#856

Merged
tseaver merged 4 commits into
googleapis:masterfrom
tseaver:825-storage_bucket_list_blobs_make_public-explicit_connection
May 11, 2015
Merged

#825: Allow passing explicit connection to 'Bucket.{list_blobs,make public}'#856
tseaver merged 4 commits into
googleapis:masterfrom
tseaver:825-storage_bucket_list_blobs_make_public-explicit_connection

Conversation

@tseaver

@tseaver tseaver commented May 1, 2015

Copy link
Copy Markdown
Contributor

Requires #853.

See #825.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 1, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2015
@tseaver tseaver mentioned this pull request May 1, 2015
Closed
@coveralls

coveralls commented May 2, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 7b99797 on tseaver:825-storage_bucket_list_blobs_make_public-explicit_connection into 8b5c5b9 on GoogleCloudPlatform:master.

@dhermes

dhermes commented May 4, 2015

Copy link
Copy Markdown
Contributor

Ping me on this when we resolve #853

@tseaver

tseaver commented May 4, 2015

Copy link
Copy Markdown
Contributor Author

Rebased against updated branch for #853.

@coveralls

coveralls commented May 5, 2015

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 1612c84 on tseaver:825-storage_bucket_list_blobs_make_public-explicit_connection into * on GoogleCloudPlatform:master*.

@tseaver

tseaver commented May 6, 2015

Copy link
Copy Markdown
Contributor Author

Rebased again against updated branch for #853.

@coveralls

coveralls commented May 6, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 219dcc6 on tseaver:825-storage_bucket_list_blobs_make_public-explicit_connection into 73a341c on GoogleCloudPlatform:master.

@tseaver

tseaver commented May 6, 2015

Copy link
Copy Markdown
Contributor Author

@dhermes any remaining issues?

@dhermes

dhermes commented May 6, 2015

Copy link
Copy Markdown
Contributor

Ditto here, was waiting on diffbase.

@tseaver

tseaver commented May 6, 2015

Copy link
Copy Markdown
Contributor Author

@dhermes I rebased it this morning on the latest from #853.

@tseaver

tseaver commented May 6, 2015

Copy link
Copy Markdown
Contributor Author

OIC, you'd like a rebase against master.

dhermes
dhermes reviewed May 6, 2015
View reviewed changes
Comment thread gcloud/storage/bucket.py Outdated

This comment was marked as spam.

Sign in to view

@coveralls

coveralls commented May 6, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 5ed6c7e on tseaver:825-storage_bucket_list_blobs_make_public-explicit_connection into aafcd2a on GoogleCloudPlatform:master.

@tseaver

tseaver commented May 7, 2015

Copy link
Copy Markdown
Contributor Author

Ideally, the backend would have a special-purpose ACL for blobs where they "inherit"/"acquire" the permissions from their bucket; one could then leave them in that state as they were created, and toggle them all public / private just by manipulating the bucket's ACL.

@coveralls

coveralls commented May 7, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 8d6ef05 on tseaver:825-storage_bucket_list_blobs_make_public-explicit_connection into aafcd2a on GoogleCloudPlatform:master.

@dhermes

dhermes commented May 7, 2015

Copy link
Copy Markdown
Contributor

Unfortunately that ideal doesn't exist.

@dhermes

dhermes commented May 11, 2015

Copy link
Copy Markdown
Contributor

LGTM

tseaver added a commit that referenced this pull request May 11, 2015
@tseaver
Merge pull request #856 from tseaver/825-storage_bucket_list_blobs_ma…
290b09e 
…ke_public-explicit_connection

#825: Allow passing explicit connection to 'Bucket.{list_blobs,make public}'
@tseaver tseaver merged commit 290b09e into googleapis:master May 11, 2015
@tseaver tseaver deleted the 825-storage_bucket_list_blobs_make_public-explicit_connection branch May 11, 2015 17:15
@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@philcoakley @busunkim96
Updates Could-KMS sample code to use V1 libraries. [(#856)](GoogleClo…
f83094f 
…udPlatform/python-docs-samples#856)
parthea pushed a commit that referenced this pull request Aug 21, 2025
@renovate-bot @Linchin
chore(deps): update all dependencies (#856)
d8020c2 
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
@renovate-bot @Linchin @parthea
chore(deps): update all dependencies (#856)
2c41d5b 
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
@gcf-owl-bot @tswast
chore(python): fix docs publish build (#856)
b743ef1 
Source-Link: googleapis/synthtool@bd9ede2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:04c35dc5f49f0f503a306397d6d043685f8d2bb822ab515818c4208d7fb2db3a

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@ohmayr
chore(librarian): onboard to librarian (#856)
9a63eca 
* chore: onboard to librarian

* chore: cleanup
parthea added a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot @parthea
chore(python): add support for python 3.11 [autoapprove] (#856)
aa761b5 
* chore(python): add support for python 3.11

Source-Link: googleapis/synthtool@7197a00
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320

* Add python 3.11 to noxfile

* add constraints file

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@arithmetic1728
fix: disable warning if quota project id provided to auth.default() (#…
951820a 
…856)

* fix: disable warning if quota project id provided to auth.default()

* add more tests
parthea pushed a commit that referenced this pull request Mar 2, 2026
@gcf-owl-bot
chore: fix prerelease_deps nox session [autoapprove] (#856)
05e4457 
Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
parthea pushed a commit that referenced this pull request Mar 9, 2026
@gcf-owl-bot
ci(python): fix path to requirements.txt in release script (#856)
f0648fa 
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Mar 9, 2026
@release-please
chore(main): release 3.24.0 (#856)
64e9e00 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @coveralls @dhermes @googlebot