Skip to content

Vision: All of the negative vision vpc sc tests should use the same file. #8439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
busunkim96 merged 2 commits into from
Jun 20, 2019
Merged

Vision: All of the negative vision vpc sc tests should use the same file. #8439

busunkim96 merged 2 commits into from
Jun 20, 2019

Conversation

@brendanlundy
Copy link
Contributor

@brendanlundy brendanlundy commented Jun 20, 2019

No description provided.

@brendanlundy brendanlundy requested a review from busunkim96 as a code owner June 20, 2019 05:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2019
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 20, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 20, 2019
@busunkim96 busunkim96 merged commit 09e36cd into googleapis:master Jun 20, 2019
@brendanlundy brendanlundy deleted the vpcsc-file branch June 20, 2019 22:07
parthea pushed a commit that referenced this pull request Oct 21, 2023
@brendanlundy @busunkim96
All of the negative vision vpc sc tests should use the same file. (#8439
6d395a8 
)

* All of the negative vision vpc sc tests should use the same file.

* One more negative vision vpc sc test image reference to update. Also increase the lro waiting seconds a bit to be safe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brendanlundy @busunkim96 @googlebot @yoshi-kokoro