Make Blob/Bucket reload() public and remove the public interface to _properties by dhermes · Pull Request #770 · googleapis/google-cloud-python

dhermes · 2015-03-28T20:53:32Z

No description provided.

coveralls · 2015-03-28T20:55:38Z

Coverage remained the same at 100.0% when pulling 87b9bf3 on dhermes:make-reload-public into 4d69bb3 on GoogleCloudPlatform:master.

Sign in to view

tseaver · 2015-03-30T18:59:05Z

LGTM. My question about return self from mutators shouldn't block the merge, but we should be dropping that pattern pretty much everywhere.

tseaver · 2015-03-30T19:18:22Z

@dhermes needs rebase?

dhermes · 2015-03-30T19:29:55Z

@tseaver Rebased and filed the bug about return self.

Will merge on Travis success.

The blob/bucket metadata was never actually accessed via the public properties `properties`.

coveralls · 2015-03-30T19:50:49Z

Changes Unknown when pulling 85aea83 on dhermes:make-reload-public into * on GoogleCloudPlatform:master*.

coveralls · 2015-03-30T19:57:38Z

Changes Unknown when pulling 85aea83 on dhermes:make-reload-public into * on GoogleCloudPlatform:master*.

Make Blob/Bucket reload() public and remove the public interface to _properties

* feat: Update Compute Engine API to revision 20230307 (#770) Source-Link: googleapis/googleapis@c2016e5 Source-Link: googleapis/googleapis-gen@0885fd7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDg4NWZkN2FlOGE4MDVhMzc3OTc0ZWRmYmE2MGFiN2M5MzI3Zjc1YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…770) * fix: export handwritten classes * change init file accordingly * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * correct import path * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix import * fix error * delete a commented out line --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-pandas/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) 🦕

* feat: add new v3.0.0 API skeleton (#745) * feat: improve rows filters (#751) * feat: read rows query model class (#752) * feat: implement row and cell model classes (#753) * feat: add pooled grpc transport (#748) * feat: implement read_rows (#762) * feat: implement mutate rows (#769) * feat: literal value filter (#767) * feat: row_exists and read_row (#778) * feat: read_modify_write and check_and_mutate_row (#780) * feat: sharded read rows (#766) * feat: ping and warm with metadata (#810) * feat: mutate rows batching (#770) * chore: restructure module paths (#816) * feat: improve timeout structure (#819) * fix: api errors apply to all bulk mutations * chore: reduce public api surface (#820) * feat: improve error group tracebacks on < py11 (#825) * feat: optimize read_rows (#852) * chore: add user agent suffix (#842) * feat: optimize retries (#854) * feat: add test proxy (#836) * chore(tests): add conformance tests to CI for v3 (#870) * chore(tests): turn off fast fail for conformance tets (#882) * feat: add TABLE_DEFAULTS enum for table method arguments (#880) * fix: pass None for retry in gapic calls (#881) * feat: replace internal dictionaries with protos in gapic calls (#875) * chore: optimize gapic calls (#863) * feat: expose retryable error codes to users (#879) * chore: update api_core submodule (#897) * chore: merge main into experimental_v3 (#900) * chore: pin conformance tests to v0.0.2 (#903) * fix: bulk mutation eventual success (#909) --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* clean unneeded fields after close * added assertions to tests --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…770) Source-Link: googleapis/synthtool@395d53a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…ntials` (#770) This includes the following properties: - `info`: This is the reverse of `from_info` defined on subclasses and useful to serialize external account credentials. - `service_account_email`: This is the corresponding service account email if impersonation is used. - `is_user`: This is `False` for workload identity pools and `True` for workforce pools (not yet supported). This can be mainly determined from the STS audience. While the properties will primarily facilitate integration with gcloud, they are publicly useful for other contexts.

* feat: add new v3.0.0 API skeleton (#745) * feat: improve rows filters (#751) * feat: read rows query model class (#752) * feat: implement row and cell model classes (#753) * feat: add pooled grpc transport (#748) * feat: implement read_rows (#762) * feat: implement mutate rows (#769) * feat: literal value filter (#767) * feat: row_exists and read_row (#778) * feat: read_modify_write and check_and_mutate_row (#780) * feat: sharded read rows (#766) * feat: ping and warm with metadata (#810) * feat: mutate rows batching (#770) * chore: restructure module paths (#816) * feat: improve timeout structure (#819) * fix: api errors apply to all bulk mutations * chore: reduce public api surface (#820) * feat: improve error group tracebacks on < py11 (#825) * feat: optimize read_rows (#852) * chore: add user agent suffix (#842) * feat: optimize retries (#854) * feat: add test proxy (#836) * chore(tests): add conformance tests to CI for v3 (#870) * chore(tests): turn off fast fail for conformance tets (#882) * feat: add TABLE_DEFAULTS enum for table method arguments (#880) * fix: pass None for retry in gapic calls (#881) * feat: replace internal dictionaries with protos in gapic calls (#875) * chore: optimize gapic calls (#863) * feat: expose retryable error codes to users (#879) * chore: update api_core submodule (#897) * chore: merge main into experimental_v3 (#900) * chore: pin conformance tests to v0.0.2 (#903) * fix: bulk mutation eventual success (#909) --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@c4dd595 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Astha Mohta <35952883+asthamohta@users.noreply.github.com>

dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 28, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2015

tseaver reviewed Mar 30, 2015
View reviewed changes

Comment thread gcloud/storage/_helpers.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes force-pushed the make-reload-public branch from 87b9bf3 to 3817154 Compare March 30, 2015 19:29

dhermes added 2 commits March 30, 2015 12:41

Renaming _reload_properties to public method reload on Blob/Bucket.

5d86096

Removing _PropertyMixin.properties public property.

85aea83

The blob/bucket metadata was never actually accessed via the public properties `properties`.

dhermes force-pushed the make-reload-public branch from 3817154 to 85aea83 Compare March 30, 2015 19:42

dhermes added a commit that referenced this pull request Mar 30, 2015

Merge pull request #770 from dhermes/make-reload-public

ef22592

Make Blob/Bucket reload() public and remove the public interface to _properties

dhermes merged commit ef22592 into googleapis:master Mar 30, 2015

dhermes deleted the make-reload-public branch March 30, 2015 19:59

dhermes mentioned this pull request Mar 30, 2015

Removing HTTP requests from Bucket logging methods. #769

Merged

dhermes mentioned this pull request Apr 9, 2015

Upgrading version to 0.5.0. #813

Merged

parthea added a commit that referenced this pull request Nov 24, 2025

fix: memory leak in bidi classes (#770)

299626d

* clean unneeded fields after close * added assertions to tests --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Mar 6, 2026

chore(deps): update actions/setup-python action to v4 (#770)

63276d0

Co-authored-by: Astha Mohta <35952883+asthamohta@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Mar 9, 2026

build: update default python version to 3.12 (#770)

7b8011a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make Blob/Bucket reload() public and remove the public interface to _properties#770

Make Blob/Bucket reload() public and remove the public interface to _properties#770
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:make-reload-public

dhermes commented Mar 28, 2015

Uh oh!

coveralls commented Mar 28, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Mar 30, 2015

Uh oh!

tseaver commented Mar 30, 2015

Uh oh!

dhermes commented Mar 30, 2015

Uh oh!

coveralls commented Mar 30, 2015

Uh oh!

coveralls commented Mar 30, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

dhermes commented Mar 28, 2015

Uh oh!

coveralls commented Mar 28, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Mar 30, 2015

Uh oh!

tseaver commented Mar 30, 2015

Uh oh!

dhermes commented Mar 30, 2015

Uh oh!

coveralls commented Mar 30, 2015

Uh oh!

coveralls commented Mar 30, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants