Adding get_for_service_account_json function in credentials. by dhermes · Pull Request #641 · googleapis/google-cloud-python

dhermes · 2015-02-13T23:05:32Z

Fixes #638.

I thought about wrapping JSON key and PKCS12 key into one method but the JSON key is actual a JSON payload with everything needed, e.g.

{
  "private_key_id": "0996.....",
  "private_key": "-----BEGIN PRIVATE KEY-----\nMIICdgIBADA.....\n-----END PRIVATE KEY-----\n",
  "client_email": "32578400.......@developer.gserviceaccount.com",
  "client_id": "32578400.........apps.googleusercontent.com",
  "type": "service_account"
}

whereas a P12 key is just the bytes in private_key (and created for PKCS12 rather than PEM).

I don't think it's worth trying to smash together the two API surfaces:

get_for_service_account_json(private_key_path, scope=None)
get_for_service_account_p12(client_email, private_key_path, scope=None)

Fixes googleapis#638.

coveralls · 2015-02-13T23:12:02Z

Coverage remained the same at 100.0% when pulling 66b47b5 on dhermes:fix-638 into c6718f3 on GoogleCloudPlatform:master.

Sign in to view

jgeewax · 2015-02-14T15:09:37Z

This LGTM.

That said - I think it'd be useful to add an example which would ideally go in a separate "auth" section in the docs. Do we have an open issue for that or should I create one?

dhermes · 2015-02-14T19:42:18Z

#633 is the issue, I actually have a branch I've been working on for awhile, I just keep getting sidetracked on it.

dhermes · 2015-02-15T18:56:24Z

Renamed to json_credentials_path. @tseaver can you give a quick look before I merge?

Sign in to view

tseaver · 2015-02-15T19:03:10Z

LGTM after pep8 passes.

Was private_key_path.

coveralls · 2015-02-15T19:12:59Z

Coverage remained the same at 100.0% when pulling a80f1dd on dhermes:fix-638 into f64fc55 on GoogleCloudPlatform:master.

Adding get_for_service_account_json function in credentials.

* feat: added dialogflow_assist_answer feat: added session_ttl feat: added human_agent_side_config feat: added suggestion_input feat: added suggest_dialogflow_assists_response feat: added suggest_entity_extraction_response PiperOrigin-RevId: 542021587 Source-Link: googleapis/googleapis@f40416d Source-Link: googleapis/googleapis-gen@04ca491 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDRjYTQ5MWRlYzhmMzUxNzNlZTU5OWQ3ZWQwNzkzNmI0MDg2ZTk2ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: added dialogflow_assist_answer feat: added session_ttl feat: added human_agent_side_config feat: added suggestion_input feat: added suggest_dialogflow_assists_response feat: added suggest_entity_extraction_response PiperOrigin-RevId: 542024928 Source-Link: googleapis/googleapis@06f7999 Source-Link: googleapis/googleapis-gen@0f124f3 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGYxMjRmM2MzN2I1YTYwNDk5MDZhOTUxNGNkOTk0ZGFmMDczZGMwMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@cb96037 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

The return type is an Awaitable that produces an AsyncIterator.

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 473833416 Source-Link: googleapis/googleapis@565a550 Source-Link: googleapis/googleapis-gen@1ee1a06 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9 feat: add firestore aggregation query apis to the stable googleapis branch PiperOrigin-RevId: 473753776 Source-Link: googleapis/googleapis@a8c6c7c Source-Link: googleapis/googleapis-gen@6e3b0d6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmUzYjBkNmVhZDQyNjVjYTZmMGFkM2UxODI5ZjRlM2E1YmMxMDlhMiJ9

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…n use by another test (#641) * test: fix run testing worker code to reduce the chance of same instance id being used by different workers * fix: remove delete of instance if it already exists, as it might be in use by another test

* docs: add section for more examples * docs: revise example usage

…641)

* chore: changing default region to us-west1 * chore(deps): update all dependencies (#602) * chore: add default_version and codeowner_team to .repo-metadata.json (#641) * feat(db_api): support stale reads (#584) * feat: removing changes from samples * chore: change region * fix: fix in sample list-backups Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Ilya Gurov <ilya.faer@mail.ru> Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>

Adding get_for_service_account_json function in credentials.

66b47b5

Fixes googleapis#638.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2015

dhermes added the api: core label Feb 14, 2015

jgeewax reviewed Feb 14, 2015
View reviewed changes

Comment thread gcloud/credentials.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

jgeewax added the auth label Feb 14, 2015

tseaver reviewed Feb 15, 2015
View reviewed changes

Comment thread gcloud/credentials.py

This comment was marked as spam.

Sign in to view

jgeewax mentioned this pull request Feb 15, 2015

Feels like we've added a bit more complexity to the datastore API, comments? #647

Closed

Using json_credentials_path in get_for_service_account_json.

a80f1dd

Was private_key_path.

dhermes force-pushed the fix-638 branch from 6695801 to a80f1dd Compare February 15, 2015 19:11

dhermes added a commit that referenced this pull request Feb 15, 2015

Merge pull request #641 from dhermes/fix-638

61c6814

Adding get_for_service_account_json function in credentials.

dhermes merged commit 61c6814 into googleapis:master Feb 15, 2015

dhermes deleted the fix-638 branch February 15, 2015 19:13

dhermes mentioned this pull request Feb 25, 2015

Upgrading version to 0.4.2. #678

Merged

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: fix types on server and bidi streaming callables (#641)

5f81714

The return type is an Awaitable that produces an AsyncIterator.

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(main): release 3.2.4 (#641)

0b18a36

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore(main): release 3.2.4 (#641)

2dcc7c4

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Mar 6, 2026

chore(deps): update dependency pyarrow to v4 (#641)

52a97ee

parthea pushed a commit that referenced this pull request Mar 9, 2026

docs: add links to samples and how to guides (#641)

af12507

* docs: add section for more examples * docs: revise example usage

parthea added a commit that referenced this pull request Mar 9, 2026

chore: add default_version and codeowner_team to .repo-metadata.json (#…

c5dc6d9

…641)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding get_for_service_account_json function in credentials.#641

Adding get_for_service_account_json function in credentials.#641
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:fix-638

dhermes commented Feb 13, 2015

Uh oh!

coveralls commented Feb 13, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

jgeewax commented Feb 14, 2015

Uh oh!

dhermes commented Feb 14, 2015

Uh oh!

dhermes commented Feb 15, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Feb 15, 2015

Uh oh!

coveralls commented Feb 15, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

dhermes commented Feb 13, 2015

Uh oh!

coveralls commented Feb 13, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

jgeewax commented Feb 14, 2015

Uh oh!

dhermes commented Feb 14, 2015

Uh oh!

dhermes commented Feb 15, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Feb 15, 2015

Uh oh!

coveralls commented Feb 15, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants