Remapping (almost) all RPC status codes to our exceptions in datastore.#2590
Merged
Conversation
theacodes
reviewed
Oct 23, 2016
| _datastore_pb2.AllocateIdsResponse) | ||
|
|
||
|
|
||
| def _grpc_catch_rendezvous(to_call, *args, **kwargs): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@jonparrott @daspecster PTAL |
Contributor
|
I like this better IMHO. |
Contributor
Author
|
FYI I am toying with Circle CI. Looks like Travis is being helpful for the time being though |
theacodes
approved these changes
Oct 24, 2016
Contributor
|
Sorry to be late to the party. Wouldn't the |
Contributor
Author
|
@tseaver I intentionally didn't do that, mindful of two things:
|
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 25, 2016
Contributor
|
@dhermes FWIW, anywhere we are currently sniffing at core/google/cloud/_testing.py
core/google/cloud/streaming/exceptions.py
core/google/cloud/streaming/http_wrapper.py
core/unit_tests/streaming/test_http_wrapper.py
datastore/google/cloud/datastore/_generated/datastore_grpc_pb2.py
datastore/google/cloud/datastore/connection.py
datastore/unit_tests/test_connection.py
docs/error-reporting-usage.rst
error_reporting/google/cloud/error_reporting/client.py
error_reporting/unit_tests/test_client.py
logging/google/cloud/logging/_gax.py
pubsub/google/cloud/pubsub/_gax.py |
Contributor
Author
|
OK. |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Remapping (almost) all RPC status codes to our exceptions in datastore.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Remapping (almost) all RPC status codes to our exceptions in datastore.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
ohmayr
pushed a commit
that referenced
this pull request
Mar 26, 2026
Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2497.
(Relevant to #2583 as well.)
FYI @jonparrott