Support entry labels#1668
Merged
tseaver merged 7 commits intoMar 28, 2016
Merged
Conversation
Labels can be passed in explicitly to the 'log_text', 'log_struct', or 'log_proto' methods. If not passed, any default values configured on the logger instance will be used. See: #1566.
|
|
||
| labels = self._get_labels(labels) | ||
| if labels is not None: | ||
| data['entries'][0]['labels'] = labels |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
It was needed earlier for batch support, but was masked by the attribute on the mock '_Logger' used by the batch tests.
| return Batch(self, client) | ||
|
|
||
| def log_text(self, text, client=None): | ||
| def _make_entry_resource(self, text=None, info=None, message=None, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM. 7 commits seems like a lot? |
Contributor
Author
Two of the commits are bugfixes for already-merged-to- |
Contributor
|
You can do with the commits as you see fit. You are go to merge on my end. |
Contributor
Author
|
I merged as-is after aborting a rebase where I tried to clean it up. |
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* fix: mock return_value should not populate oneof message fields
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
…nt (#1668) skip failing samples due to public access prevention enforcement. More Details on b/469643064
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetched entries expose labels set on the back-end.
When logging, labels can be passed in explicitly to the
log_text,log_struct, orlog_protomethods. If not passed, any default values configured on the logger instance will be used.See: #1566.