Using protobuf CommitRequest in datastore Connection.commit.#1341
Merged
dhermes merged 1 commit intoJan 7, 2016
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
It makes me queasy to think about reusing a batch or a transaction. If somebody wanted to examine the |
This is towards googleapis#1288 in preparation for the upgrade to `v1beta3`. In particular, a single `Mutation` protobuf instance in `v1beta3` is not sufficient to contain all changes to be committed, so we use the container that is up one level in the hierarchy.
a1194f5 to
7f1b786
Compare
Contributor
Author
|
OK. Should I file an issue to move the tombstone behavior into PS I just rebased, had a merge issue. |
Contributor
|
I think we could just open an issue and go on. |
Contributor
Author
|
LGTY to merge? |
Contributor
Author
|
Filed #1366 |
Contributor
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 7, 2016
Using protobuf CommitRequest in datastore Connection.commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is towards #1288 in preparation for the upgrade to
v1beta3. In particular, a singleMutationprotobuf instance inv1beta3is not sufficient to contain all changes to be committed, so we use the container that is up one level in the hierarchy.