fix: sometimes changes to the draggable prop don't get propagated#994
Open
tagoro9 wants to merge 1 commit intogoogle-map-react:masterfrom
Open
fix: sometimes changes to the draggable prop don't get propagated#994tagoro9 wants to merge 1 commit intogoogle-map-react:masterfrom
tagoro9 wants to merge 1 commit intogoogle-map-react:masterfrom
Conversation
| shouldComponentUpdate(nextProps, nextState) { | ||
| // draggable does not affect inner components | ||
| return ( | ||
| !shallowEqual( |
Author
There was a problem hiding this comment.
It's still not working for me. Does the sandbox in the PR description work for you?
When I check the draggable checkbox at the top, only the third map becomes draggable, but not the first two. I would expect these 2 to also be draggable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where a change to the draggable prop would not make the map draggable by not omitting the prop inside the
shouldComponentUpdateprop.If we change the prop but there is no other prop change the map behavior won't get updated, as that is done inside the
componentDidUpdatefunction.You can see the issue reproduced in this sandbox: https://codesandbox.io/s/distracted-wright-hrs51?file=/src/App.js
When you make the map draggable only the last map becomes draggable as there is another prop change, while the first 2 can't be dragged (the second one is expected as the code in
componentDidUpdateomits those).Fixes #978