@stephenfarrar What do you think about this? Given its part of the code you've been working with.

Looks good to me.

Just pushed an explanation, and thanks for looking at this pull request so fast!

@mtogstad Thank you very much for this! Please update to 1.0.3 and let me know how it works. Feel free to make more PRS, we need more help!

@mtogstad Hey, I know that this issue is closed, but I'm curious, how did this help with the canvas markers? I am using it for a similar use case & facing the exact same problem. Could you share the relevant change you made in this repo, https://github.com/istarkov/google-map-thousands-markers, which fixed the issue?

@palashkaria Which version are you using? We're currently at 1.0.5

I'm on 1.0.5 itself, but the issue is not with this lib, it's with the canvas implementation (https://github.com/istarkov/google-map-thousands-markers).

What I understood from this change is that I have to pass seLatLng to CanvasTile in that implementation. But that doesn't seem to work..

@palashkaria Oh yes, what changed is that you can pass either

seLatLng={[lat, lng]}

or

seLat={lat} seLng={lng}

I think it's like seLatLng={{lat, lng}}. But question is, specifically how does it help in those before/after images posted above, from the 'google-map-thousands-markers' example. I'm trying something here, but it doesn't seem to work..

palashkaria/google-map-thousands-markers@500dacf#diff-4848da3e28fb800ab253319bb2777f2e

@palashkaria That should work given @mtogstad's change, but there might be a chance that you dont need that seLatLng anymore as we went through some interesting changes in the way markers are drawn. What exactly you want to accomplish? Could you provide a live example?

I think the best person to answer would be @mtogstad, as he did the change and tested it locally.

@itsmichaeldiego here's an updated codesandbox version of istarkov's example, which also has the same issue. You can check it out here:

https://codesandbox.io/s/kx7lo2plq5
https://kx7lo2plq5.codesandbox.io/

This also has the seLatLng change that I made in src/CanvasMap. It'd be helpful if you/ @mtogstad could take a look & figure out what's going wrong here

@palashkaria I'm facing the same problem. Did you get a solution?

@punnone [I work with @palashkaria] No. We are still trying to figure it out.

Fixed it. 2 things have to be done.

1. Adding a seLatLng to the tile [CanvasMap.js]

tiles[key] = {
        ...tile2LatLng({ x, y }, zoom),
        seLatLng: { ...tile2LatLng({ x: x + 1, y: y + 1 }, zoom) },
        x,
        y,
        markers: []
   };

2. Remove explicit width from the canvas tile [CanvasTile.js]

const canvasStyle = {
  width: "100%",
  height: "100%"
};

Updated the codesandbox for reference: https://codesandbox.io/s/6v5vx7z65w

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.