added if statement in onRemove() function#555
Merged
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom Apr 17, 2018
Merged
added if statement in onRemove() function#555itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
Conversation
Added an if statement in onRemove() function that checks if "this.div" is defined before calling ReactDOM.unmountComponentAtNode(this.div). This is done to avoid throwing an "unmountComponentAtNode(...): Target container is not a DOM element" error. I ran into this error while using google-map-react with React Router and switching between tabs rapidly to stress test my application.
Member
|
@atkallie Thanks, defensive programming is always a plus. |
itsmichaeldiego
approved these changes
Apr 17, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an if statement in
onRemove()function that checks ifthis.divis defined before callingReactDOM.unmountComponentAtNode(this.div). This is done to avoid throwing anunmountComponentAtNode(...): Target container is not a DOM elementerror. I ran into this error while using google-map-react with React Router and switching between tabs rapidly to stress test my application.