Add fullscreen check for Internet explorer 11#485
Merged
itsmichaeldiego merged 3 commits intogoogle-map-react:masterfrom Jan 4, 2018
Merged
Add fullscreen check for Internet explorer 11#485itsmichaeldiego merged 3 commits intogoogle-map-react:masterfrom
itsmichaeldiego merged 3 commits intogoogle-map-react:masterfrom
Conversation
Fixing marker position in Internet Explorer 11 in fullscreen mode. Fixing: google-map-react#484
Member
itsmichaeldiego
left a comment
There was a problem hiding this comment.
This if is getting really big, could we create a function called isFullScreen and move all this logic there to make it cleaner? Thanks.
Contributor
Author
|
Code is moved to function |
Contributor
|
Great job guys, would love to see this merged as well to complete #452. Thanks! |
itsmichaeldiego
approved these changes
Jan 4, 2018
Member
|
@omladek Good job, thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing marker position in Internet Explorer 11 in fullscreen mode.
Fixing: #484