#add handlers for fly update layers#272
Merged
istarkov merged 3 commits intogoogle-map-react:masterfrom Nov 7, 2016
ipostol:master
Merged
#add handlers for fly update layers#272istarkov merged 3 commits intogoogle-map-react:masterfrom ipostol:master
istarkov merged 3 commits intogoogle-map-react:masterfrom
ipostol:master
Conversation
istarkov
reviewed
Nov 7, 2016
src/google_map.js
Outdated
| this.map_.setOptions(options); | ||
| } | ||
|
|
||
| if (!isEqual(nextProps.layerTypes.sort(), this.props.layerTypes.sort())) { |
Collaborator
There was a problem hiding this comment.
imo it's on user to sort layers, and to support referential equality. I don't like any kind of isEqual + sort checks here.
Contributor
Author
|
@istarkov, removed sort/isEqual logic, left only ref equal |
Collaborator
|
Thank you! |
Collaborator
|
0.21.3 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this is update for resolve fly updates layerTypes by new props (now they can inititialize with map 1 time)