Fix unreliable window and document detection#246
Merged
istarkov merged 3 commits intogoogle-map-react:masterfrom Sep 23, 2016
viktorbezdek:master
Merged
Fix unreliable window and document detection#246istarkov merged 3 commits intogoogle-map-react:masterfrom viktorbezdek:master
window and document detection#246istarkov merged 3 commits intogoogle-map-react:masterfrom
viktorbezdek:master
Conversation
Signed-off-by: Viktor Bezděk <viktor.bezdek@siteone.cz>
…ts published to fix ssr issues Signed-off-by: Viktor Bezděk <viktor.bezdek@siteone.cz>
Collaborator
|
Thank you!
|
Author
I'll fix files in the repo in sec. Will let you know. |
Author
|
The last commit is reverted. If you accept the pull request, please publish the patch asap. |
Collaborator
|
Thank you!!! Will publish today. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method used for detecting DOM availability was sloppy and breaks server side rendering in some cases. This new approach fix cases when global variable window is defined in NodeJS by checking presence of
window.documentandwindow.document.createElementwhich are used in element resize detection.