call zoomControlClickTime on all clicks#211
call zoomControlClickTime on all clicks#211itsmichaeldiego merged 3 commits intogoogle-map-react:masterfrom
Conversation
|
Thank you!, |
|
this seems to look ok in chrome. |
|
I need to check this with some of our production code, which causes an addition of double raf hack, it will take some time. |
|
@alex-e-leon Thanks for your contribution. We would like to have this change but it is having conflicts. Would you mind to add a commit to fix it? Thanks. |
|
@itsmichaeldiego updated |
|
@alex-e-leon Thanks, I am still a little bit worried about what @istarkov mentioned earlier. As this fix was supposed to improve chrome's visual behavior. Would you mind sharing a test-video? Otherwise give me some time and I will test it thoroughly. Thanks in advance. |
|
No problem @itsmichaeldiego I ended up working around the bug, and I haven't worked on this problem in a while, so I don't have any video I can share. I also don't mind if you close it tbh, but if you feel like working on it let me know how you go! |
|
@alex-e-leon Oh Alex, thanks and no worries. I will take a look and test it as soon as I have some spare time. Thanks for fixing the conflicts! |
|
@alex-e-leon I will merge this soon for next release. |
|
@alex-e-leon I am going to merge this soon, sorry for the delay! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fixes an issue where zoomControlClickTime doesn't get called on any clicks not handled by google maps, so if a marker click function should change the zoom level you receive the
GoogleMap bounds not eq:error.