This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Fix Model dataclass #439
Merged
Fix Model dataclass #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dataclass Model misses max_temperature field which brakes list_models()
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Change-Id: I0cdacd0134c868044ae5b96322b266224d7b8a69
MarkDaoust
previously approved these changes
Jul 8, 2024
Collaborator
Change-Id: I5db22405c93b66fd268b19f1e081dc24f3246d24
MarkDaoust
approved these changes
Jul 8, 2024
Collaborator
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataclass Model misses max_temperature field which brakes list_models()
Description of the change
Fix Model dataclass with adding max_temperature field
Motivation
list_models() doesn't work without max_temperature
Type of change
Bug fix
Checklist
git pull --rebase upstream main).