Repository navigation
refactor: strengthen kill input check - #1341
Merged
Merged
Conversation
antongolub
force-pushed
the
kill-check-2
branch
from
September 20, 2025 07:00
6b0e394 to
a3b7ce6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR strengthens input validation for the kill function to prevent objects with toString methods from being passed as process IDs, addressing a potential security/reliability issue.
- Enhanced the
killfunction's input validation to explicitly check for number and string types - Added comprehensive test coverage for the new validation behavior
- Updated version numbers across the codebase
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/core.ts | Enhanced kill function input validation to check for number/string types before regex validation |
| test/core.test.js | Added test case for object with toString method to verify rejection |
| package.json | Version bump to 8.8.3 |
| src/versions.ts | Updated zx version to 8.8.3 |
| build/index.cjs | Updated compiled version number |
| build/core.cjs | Updated compiled kill function with new validation logic |
| .size-limit.json | Adjusted size limits for bundle changes |
| .github/workflows/publish.yml | Added release tag validation workflow step |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
antonmedv
approved these changes
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continues #1339