refactor: rm redundant internal vars - #1278
Merged
Merged
Conversation
antongolub
commented
Jul 20, 2025
Collaborator
- Tests pass
- Appropriate changes to README are included in PR
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to remove redundant internal variables and simplify code structure while maintaining the same functionality. The changes focus on eliminating unnecessary variable assignments and streamlining conditional logic.
- Simplified the
onceutility function implementation using comma operator - Removed redundant variable assignments (
selfvariable whenthiscan be used directly) - Inverted conditional logic for better readability and reduced nesting
- Updated size limits to reflect the reduced bundle size from these optimizations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/util.test.js | Added imports and test coverage for identity and once functions |
| src/util.ts | Refactored once function to use comma operator instead of separate statements |
| src/core.ts | Removed redundant self variable assignments and inverted conditional logic |
| build/util.cjs | Compiled output reflecting the once function refactoring |
| build/core.cjs | Compiled output reflecting the core.ts changes |
| .size-limit.json | Updated size limits to reflect reduced bundle size |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.