Skip to content

feat: expose ProcessPromise stage - #1077

Merged
antongolub merged 14 commits into
google:mainfrom
easymikey:refactor-proccess-promise
Jan 11, 2025
Merged

feat: expose ProcessPromise stage#1077
antongolub merged 14 commits into
google:mainfrom
easymikey:refactor-proccess-promise

Conversation

@easymikey

@easymikey easymikey commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

@antongolub Did you mean something like that?

This is a draft, I need to understand if I chose the right approach.

Fixes #967

  • Tests pass
  • Appropriate changes to README are included in PR

@easymikey
easymikey force-pushed the refactor-proccess-promise branch from e74763e to ad5c167 Compare January 10, 2025 15:23
@easymikey
easymikey marked this pull request as draft January 10, 2025 17:28
@easymikey easymikey changed the title Draft: refactor: add internal state marker refactor: add internal state marker Jan 10, 2025
@antongolub

antongolub commented Jan 10, 2025

Copy link
Copy Markdown
Collaborator

Provide a test for get stage(). And state machine description for the docs plz.

@antongolub
antongolub self-requested a review January 10, 2025 18:38
@easymikey

Copy link
Copy Markdown
Contributor Author

Provide a test for get stage(). And state machine description for the docs plz.

Okey, I'll finish today

@easymikey
easymikey marked this pull request as ready for review January 11, 2025 13:01
Comment thread src/core.ts Outdated
Comment thread docs/process-promise.md Outdated
@easymikey
easymikey requested a review from antongolub January 11, 2025 18:45
Comment thread test/core.test.js Outdated
Comment thread test/core.test.js Outdated
Comment thread test/core.test.js Outdated
@antongolub
antongolub self-requested a review January 11, 2025 21:23

@antongolub antongolub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@antongolub
antongolub merged commit 49a82c4 into google:main Jan 11, 2025
@antongolub antongolub changed the title refactor: add internal state marker feat: expose ProcessPromise stage Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: refactor ProcessPromise internal state markers

2 participants