Skip to content

fix: timeout signal override #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antongolub merged 2 commits into from
Jan 10, 2025
Merged

fix: timeout signal override #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8f7ef2
fix: `timeout()` should not override predefined `_timeoutSignal`
antongolub Jan 10, 2025
3db02fe
test(bench): add buf-join aliternatives
antongolub Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,10 @@ export class ProcessPromise extends Promise<ProcessOutput> {
return this
}

timeout(d: Duration, signal = $.timeoutSignal): ProcessPromise {
timeout(
d: Duration,
signal = this._timeoutSignal || $.timeoutSignal
): ProcessPromise {
if (this._resolved) return this

this._timeout = parseDuration(d)
Expand Down
12 changes: 12 additions & 0 deletions test/bench/buf-join.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,24 @@ cronometro({
buf_arr_reduce_decode() {
BUF_ARR.reduce((acc, buf) => acc + decoder.decode(buf), '')
},
buf_arr_reduce_to_string() {
BUF_ARR.reduce((acc, buf) => acc + buf.toString('utf8'), '')
},
buf_arr_for_decode() {
let res = ''
for (const buf of BUF_ARR) {
res += decoder.decode(buf)
}
},
buf_arr_while_decode() {
let res = ''
let i = 0
const bl = BUF_ARR.length
while (i < bl) {
res += decoder.decode(BUF_ARR[i])
i++
}
},
buf_arr_join() {
BUF_ARR.join('')
},
Expand Down