drop support for Py2 and Py3.4 #498
Conversation
hugovk
left a comment
There was a problem hiding this comment.
These can be tidied up:
fire/__main__.py:64: if sys.version_info.major == 3 and sys.version_info.minor < 5:
fire/__main__.py:72: elif sys.version_info.major == 3:
fire/helptext.py:540: if sys.version_info[0:2] >= (3, 3):
fire/helptext.py:540: if sys.version_info[0:2] >= (3, 3):
fire/helptext_test.py:133: sys.version_info[0:2] < (3, 5),
fire/helptext_test.py:150: sys.version_info[0:2] < (3, 5),
fire/helptext_test.py:168: sys.version_info[0:2] < (3, 5),
fire/helptext_test.py:186: sys.version_info[0:2] < (3, 5),
fire/testutils.py:76: if sys.version_info.major == 2:
universal = 1 can be removed:
setup.cfg:2: universal = 1
setup.py
Outdated
| A library for automatically generating command line interfaces.""".strip() | ||
|
|
||
| DEPENDENCIES = [ | ||
| 'six', |
There was a problem hiding this comment.
The six dependency can be replaced and removed.
Running pyupgrade **/**.py --py3-plus can help, and also upgrade a lot of other syntax.
.github/scripts/requirements.txt
Outdated
| python-Levenshtein <0.20.9 ; python_version == '2.7' | ||
| levenshtein <=0.25.0 ; python_version >= '3.5' | ||
| levenshtein <=0.25.0 | ||
| mock <6.0.0 |
There was a problem hiding this comment.
This dependency can be removed and replaced with stdlib's unittest.mock.
|
Why choose 3.5 as the lower bound? 3.8 is the lowest supported: https://devguide.python.org/versions/ |
O wpul;d do it too, but following |
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
The Great Six Cleanser are watching you https://wiki.debian.org/Python3-six-removal :-) |
|
cc: @dbieber |
|
Thanks for putting this together. I'm going to try to get the Python 2 specific stuff out of the codebase now (airplane wifi permitting!). |
sure, @dbieber so shall I continue with it? |
|
@dbieber friendly ping if we shall land it or close it? :) |
I am trying to address #420 (comment)
cc: @hugovk if you would be so kind (as always you have been) and may help me, check I missed 🐰