Skip to content

Conversation

@AIweimd
Copy link

@AIweimd AIweimd commented Jun 9, 2020

Hi,
The mock object library has been integrated into the unittest module in python3.x, so I try to add extention like this.

try:

import mock  # python 2.x

except ModuleNotFoundError:

from unittest import mock  # python 3.x

Thanks for watching.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Author has not signed CLA label Jun 9, 2020
@dbieber
Copy link
Collaborator

dbieber commented Dec 16, 2020

Thanks for the PR!

If I understand correctly, mock as a package from pypi continues to work in Python 3, and this change just allows us to drop the dependency on mock for testing purposes for Python 3.

Can you confirm I'm understanding correctly?

Could you also sign the CLA, please?

@a-detiste
Copy link

The try/except should be the other wat around ( unittest.mock is newer than mock nowadays ),
I can provide a PR

@dbieber
Copy link
Collaborator

dbieber commented Sep 22, 2024

We've moved entirely to unittest.mock #545

@dbieber dbieber closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Author has not signed CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants