Skip to content

fix: add @override decorators to LoggingPlugin (#4496)#4544

Open
Fangmbeng wants to merge 2 commits intogoogle:mainfrom
Fangmbeng:fix/4496-add-override-decorators-logging-plugin
Open

fix: add @override decorators to LoggingPlugin (#4496)#4544
Fangmbeng wants to merge 2 commits intogoogle:mainfrom
Fangmbeng:fix/4496-add-override-decorators-logging-plugin

Conversation

@Fangmbeng
Copy link

@Fangmbeng Fangmbeng commented Feb 18, 2026

Please ensure you have read the contribution guide before creating a pull request.

fix: add @OverRide decorators to LoggingPlugin (#4496)

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 18, 2026

Summary of Changes

Hello @Fangmbeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the maintainability and readability of the LoggingPlugin by introducing @override decorators. This change makes the code's intent clearer, helping developers identify methods that are meant to override parent class methods, which can prevent subtle bugs arising from method signature mismatches during refactoring or inheritance changes.

Highlights

  • Code Clarity: Added @override decorators to all overridden methods within the LoggingPlugin class, explicitly marking methods that are intended to override a method in a superclass.
  • Dependency Update: Imported the override decorator from typing_extensions to enable the use of this feature.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/google/adk/plugins/logging_plugin.py
    • Added @override decorators to various callback methods.
    • Imported override from typing_extensions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 18, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds @override decorators to the methods in LoggingPlugin that are inherited from the BasePlugin class. This is a valuable improvement that enhances code clarity and enables static analysis tools to verify that these methods correctly override their counterparts in the base class. The changes are well-implemented and follow modern Python best practices. No issues were found in the changes.

@adk-bot
Copy link
Collaborator

adk-bot commented Feb 18, 2026

Response from ADK Triaging Agent

Hello @Fangmbeng, thank you for creating this PR!

To help us review this pull request, could you please fill out the information in the PR description, including a link to the relevant issue and a testing plan?

This information will help reviewers to review your PR more efficiently. You can find more details in our contribution guidelines. Thanks!

@ryanaiagent ryanaiagent self-assigned this Feb 19, 2026
@ryanaiagent
Copy link
Collaborator

ryanaiagent commented Feb 19, 2026

Hi @Fangmbeng , Thank you for your contribution! We need additional information to start the review. Please provide a clear description of the changes, and if applicable, supporting details such as screenshots, logs, and/or unit tests. Providing more context will help us understand the purpose of your contribution and expedite the review process.

@ryanaiagent ryanaiagent added request clarification [Status] The maintainer need clarification or more information from the author core [Component] This issue is related to the core interface and implementation labels Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@ryanaiagent ryanaiagent

Labels

core [Component] This issue is related to the core interface and implementation request clarification [Status] The maintainer need clarification or more information from the author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fangmbeng @adk-bot @ryanaiagent

Comments