fix(artifacts): accept dict-shaped artifacts in InMemoryArtifactService (#3495)#4540
fix(artifacts): accept dict-shaped artifacts in InMemoryArtifactService (#3495)#4540Fangmbeng wants to merge 3 commits intogoogle:mainfrom
Conversation
Summary of ChangesHello @Fangmbeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the flexibility of artifact handling by enabling Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @Fangmbeng, thank you for creating this PR! Could you please fill out the PR template in the description? This includes providing a link to an existing issue or a description of the change, a testing plan, and filling out the checklist. This information will help reviewers to review your PR more efficiently. Thanks! |
There was a problem hiding this comment.
Code Review
The pull request successfully implements support for dict-shaped artifacts in the save_artifact method across various artifact services. This enhancement improves the flexibility of the API, especially when dealing with serialized data. I have identified a few minor issues regarding the .gitignore configuration and indentation consistency in the newly added tests.
I am having trouble creating individual review comments. Click here to see my feedback.
.gitignore (107)
Adding a specific, PR-related file like DICT_ARTIFACTS_FIX.md to the repository's .gitignore is generally discouraged. If this is a temporary local file, it's better to use your local .git/info/exclude or a global gitignore file. If it's meant to be a permanent part of the repository, it should probably be committed rather than ignored.
tests/unittests/artifacts/test_artifact_service.py (861-867)
The indentation in this block is inconsistent with the rest of the file. The project appears to use 2-space indentation, but this block uses 4 spaces for the assert statements relative to the if/else keywords.
if loaded.text is not None:
assert loaded.text == "Hello, World!"
else:
assert (
loaded.inline_data is not None
and loaded.inline_data.data == b"Hello, World!"
)
9538df5 to
984b680
Compare
|
Hi @Fangmbeng, Thank you for your contribution! We need additional information to start the review. Please provide a clear description of the changes, and if applicable, supporting details such as screenshots, logs, and/or unit tests. Providing more context will help us understand the purpose of your contribution and expedite the review process. |
fix(artifacts): accept dict-shaped artifacts in InMemoryArtifactService (#3495)
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.