Skip to content

Feature/create groups and projects#708

Open
MihkelKillo wants to merge 10 commits intogitlabform:mainfrom
MihkelKillo:feature/create-groups-and-projects
Open

Feature/create groups and projects#708
MihkelKillo wants to merge 10 commits intogitlabform:mainfrom
MihkelKillo:feature/create-groups-and-projects

Conversation

@MihkelKillo
Copy link
Copy Markdown

A small addition to automatically create groups, subgroups and projects.

Only usable when using target "ALL_DEFINED" and creates the elements in Gitlab when key "create_if_not_found" with value "true" is present. Doesn't affect any already existing parts when this key is not present (or is not truthy).

Solves issue #399 as proposed by user kriko

@MihkelKillo MihkelKillo had a problem deploying to Integrate Pull Request March 14, 2024 14:48 — with GitHub Actions Failure
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.22%. Comparing base (b4a9386) to head (6a11edd).
⚠️ Report is 628 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   84.39%   80.22%   -4.18%     
==========================================
  Files          69       69              
  Lines        2749     2771      +22     
==========================================
- Hits         2320     2223      -97     
- Misses        429      548     +119     
Files with missing lines Coverage Δ
gitlabform/lists/groups.py 98.11% <100.00%> (+0.49%) ⬆️
gitlabform/lists/projects.py 95.50% <100.00%> (+0.63%) ⬆️

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MihkelKillo MihkelKillo had a problem deploying to Integrate Pull Request March 14, 2024 15:31 — with GitHub Actions Failure
@MihkelKillo MihkelKillo had a problem deploying to Integrate Pull Request March 14, 2024 15:32 — with GitHub Actions Failure
@kriko
Copy link
Copy Markdown
Contributor

kriko commented Mar 15, 2024

@amimas or @gdubicki - could we request a review and a merge, if it's okay?

@MihkelKillo MihkelKillo had a problem deploying to Integrate Pull Request March 18, 2024 12:35 — with GitHub Actions Failure
@MihkelKillo MihkelKillo had a problem deploying to Integrate Pull Request March 18, 2024 12:50 — with GitHub Actions Failure
@MihkelKillo MihkelKillo had a problem deploying to Integrate Pull Request March 19, 2024 15:08 — with GitHub Actions Failure
@MihkelKillo MihkelKillo temporarily deployed to Integrate Pull Request March 19, 2024 15:10 — with GitHub Actions Inactive
@kriko
Copy link
Copy Markdown
Contributor

kriko commented Mar 19, 2024

@amimas or @gdubicki - we have fixed the tests, requesting a review. :)

@kriko
Copy link
Copy Markdown
Contributor

kriko commented Mar 21, 2024

@amimas , can you review please?

@MihkelKillo MihkelKillo had a problem deploying to Integrate Pull Request March 25, 2024 09:44 — with GitHub Actions Failure
@amimas
Copy link
Copy Markdown
Collaborator

amimas commented Mar 30, 2024

Thanks for the PR. Let's finish the discussions and suggestions in the issue first.

path_elements = project.split("/")
parent_name, project_name = "/".join(path_elements[:-1]), path_elements[-1]
parent_id = self.gitlab.get_group_id_case_insensitive(parent_name)
self.gitlab.create_project(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should aim to use python gitlab apis rather than the existing GLF implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants