Do not add entities that are marked as delete#669
Open
KrystianOcado wants to merge 2 commits intogitlabform:mainfrom
Open
Do not add entities that are marked as delete#669KrystianOcado wants to merge 2 commits intogitlabform:mainfrom
KrystianOcado wants to merge 2 commits intogitlabform:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 82.54% 82.74% +0.20%
==========================================
Files 74 74
Lines 2904 2904
==========================================
+ Hits 2397 2403 +6
+ Misses 507 501 -6
🚀 New features to boost your workflow:
|
Collaborator
|
Hi. Thanks for this PR. Is there an existing open issue for it? Could you please reference it or create a new issue? I didn't completely follow the problem you mentioned. Also it seems the acceptance tests are failing. |
Collaborator
|
Hi @KrystianOcado - Did you get a chance to look into what I mentioned previously ☝️ ? |
Contributor
Author
a17ee88 to
ce61969
Compare
befeafd to
f5d9d4a
Compare
Member
|
Hey @KrystianOcado! We would love to get your contribution merged, but the tests need to pass first. Can you find the time to revisit this PR and fix them please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Current version of gitlabform tries to add entities (e.g. variables) that are present only in config, even if they are marked as delete.
This means, that on first run, gitlabform will delete entity "foo" and on the next run it will try to add it again.
This should fix this issue.