Merge pull request DataDog#4449 from DataDog/bbujon/serial-failed-metrics

PerfectSlayer · web-flow · commit ff25097d61c9 · 2022-12-19T16:52:47.000+01:00
Add metric for serialization failure
diff --git a/dd-trace-core/src/main/java/datadog/trace/core/monitor/HealthMetrics.java b/dd-trace-core/src/main/java/datadog/trace/core/monitor/HealthMetrics.java
@@ -61,6 +61,8 @@ public class HealthMetrics implements AutoCloseable {
       CountersFactory.createFixedSizeStripedCounter(8);
   private final FixedSizeStripedLongCounter samplerKeepDroppedTraces =
       CountersFactory.createFixedSizeStripedCounter(8);
+  private final FixedSizeStripedLongCounter serialFailedDroppedTraces =
+      CountersFactory.createFixedSizeStripedCounter(8);
   private final FixedSizeStripedLongCounter unsetPriorityDroppedTraces =
       CountersFactory.createFixedSizeStripedCounter(8);
 
@@ -174,8 +176,7 @@ public void onSerialize(final int serializedSizeInBytes) {
   }
 
   public void onFailedSerialize(final List<DDSpan> trace, final Throwable optionalCause) {
-    // TODO - DQH - make a new stat for serialization failure -- or maybe count this towards
-    // api.errors???
+    serialFailedDroppedTraces.inc();
   }
 
   public void onCreateSpan() {
@@ -239,6 +240,7 @@ private static class Flush implements AgentTaskScheduler.Task<HealthMetrics> {
     private static final String[] USER_KEEP_TAG = new String[] {"priority:user_keep"};
     private static final String[] SAMPLER_DROP_TAG = new String[] {"priority:sampler_drop"};
     private static final String[] SAMPLER_KEEP_TAG = new String[] {"priority:sampler_keep"};
+    private static final String[] SERIAL_FAILED_TAG = new String[] {"failure:serial"};
     private static final String[] UNSET_TAG = new String[] {"priority:unset"};
 
     @Override
@@ -267,6 +269,11 @@ public void run(HealthMetrics target) {
           target.statsd, "queue.dropped.traces", target.samplerDropDroppedTraces, SAMPLER_DROP_TAG);
       reportIfChanged(
           target.statsd, "queue.dropped.traces", target.samplerKeepDroppedTraces, SAMPLER_KEEP_TAG);
+      reportIfChanged(
+          target.statsd,
+          "queue.dropped.traces",
+          target.serialFailedDroppedTraces,
+          SERIAL_FAILED_TAG);
       reportIfChanged(
           target.statsd, "queue.dropped.traces", target.unsetPriorityDroppedTraces, UNSET_TAG);
       reportIfChanged(target.statsd, "queue.enqueued.spans", target.enqueuedSpans, NO_TAGS);
