change gren to take only pull requests that have been merged#154
Merged
alexcanessa merged 2 commits intogithub-tools:masterfrom Apr 12, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
===========================================
- Coverage 86.06% 37.42% -48.65%
===========================================
Files 7 7
Lines 323 334 +11
===========================================
- Hits 278 125 -153
- Misses 45 209 +164
Continue to review full report at Codecov.
|
alexcanessa
approved these changes
Apr 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #133
Until Prs was retrieve using the List issues endpoint endpoint in the github api.
The problem with this endpoint it doesn't have the information about if the prs were merged. This information is vital because Gren should take only merged pr.
To solve this issue, the List issues endpoint was replace by the List pull request endpoint